search

gridscale / gsclient-go

The official gridscale API client written in Go
https://gridscale.io
MIT License
7 stars 7 forks source link

Make Q35 the default profile #161

Closed bkircher closed 3 years ago

bkircher commented 3 years ago

When creating servers and ServerCreateRequest.ServerHardwareProfile is omitted the resulting profile is pc-i440fx-2.4 which is a weird choice for a default.

When doing the same thing in the panel, I get pc-q35-2.10 ("q35" in the API docs) which is a much saner choice. Please consider changing default profile and set it explicitly to "q35". Also update the docs for ServerCreateRequest.ServerHardwareProfile, "HardwareProfile is not set => server hardware is normal type" is really not saying anything at all.

nvthongswansea commented 3 years ago

@bkircher is the server hardware profile set to "default" (as in https://gridscale.io/en/api-documentation/index.html#operation/createServer) when the ServerCreateRequest.ServerHardwareProfile is omitted?

bkircher commented 3 years ago

Yep. But that profile is pretty much useless. Also panel does select q35 if the user does not select anything else.

nvthongswansea commented 3 years ago

Yep. But that profile is pretty much useless. Also panel does select q35 if the user does not select anything else.

I think this issue is from the backend side. Since the sdk just follows the API docs.

bkircher commented 3 years ago

I think this issue is from the backend side.

Yep, absolutely. Meanwhile let's set a sensible default.

MarcHarriss commented 3 years ago

This is now default functionality via the API. The q35 hardware profile will now be set by default, therefore closing the issue.