gridscale / gscloud

The official command-line interface for the gridscale API
https://gridscale.io/
MIT License
16 stars 8 forks source link

Source releases are missing version information #131

Closed fkr closed 3 years ago

fkr commented 3 years ago

The source releases are missing the version infos that are compiled into the binaries. Explanation in this PR: https://github.com/gridscale/gscloud/pull/128

Conclusion: needs to be done with goreleaser.

bkircher commented 3 years ago

Perfect, was just about to do this :smiley:

Conclusion: needs to be done with goreleaser.

Or somehow massaged into GH Actions. For ideas also see PR #128 .

neur0manc commented 3 years ago

128 is closed a while now, is there a strategy on how to go forward with this?

bkircher commented 3 years ago

Yes. With commits 31f64b8849e32887fd2fa3b5185aa27af01a7b6b and 714dfbee959e0745dd4517cac5023852d735f68d and recently released Git v2.32.0 (annoncement) we create a file RELEASE.txt that contain GIT_COMMIT and VERSION variables. This should happen automatically when GitHub builds the release archive (I hope, not sure what Git version or implementation they use internally).

Things left doing:

bkircher commented 3 years ago

Seems like %(describe) is not yet working on GitHub: https://github.community/t/support-for-describe-in-export-subst/196618