gridscale / gscloud

The official command-line interface for the gridscale API
https://gridscale.io/
MIT License
16 stars 8 forks source link

fix iso-image ls --quiet to show only image-ids #135

Closed ghostwheel42 closed 3 years ago

ghostwheel42 commented 3 years ago

closes #134

nvthongswansea commented 3 years ago

In stead of if-else, you could do if-return. That would give a bit of performance, since it returns right away when the condition is met (instead of checking other conditions and then return at the end of the function).

ghostwheel42 commented 3 years ago

Yes, I know. I’ve decided to stick to the if-else style already present in the existing code, even though this is not the normally used go style. I didn’t want to change too much of the existing code.

nvthongswansea commented 3 years ago

LGTM @bkircher any thoughts?

bkircher commented 3 years ago

Ja, looks good.

bkircher commented 3 years ago

Thanks @ghostwheel42 , @nvthongswansea!