search

gridsome / eslint-plugin-gridsome

ESLint plugin for Gridsome
https://eslint.gridsome.org/
MIT License
47 stars 6 forks source link

Yarn 2 warning #57

Open hacknug opened 4 years ago

hacknug commented 4 years ago

I was just trying out Yarn 2 to see if there were any major issues with Gridsome and got this warning:

eslint-plugin-gridsome@npm:1.4.0 doesn't provide eslint@^5.0.0 || ^6.0.0 requested by vue-eslint-parser@npm:6.0.5

Guessing eslint should be listed either in dependencies or peerDependencies? 🤔

tyankatsu0105 commented 4 years ago

@hacknug Umm... Maybe we need to add engines to package.json. Like this:

{
  "engines": {
    "yarn": "^1.22.0"
  }
}

1.22.0 is current's stable version of Yarn.

hacknug commented 4 years ago

I don't think that's the way to solve it since people should (ideally) be able to also use npm and pnpm to manage their dependencies.

Guessing eslint should be listed either in dependencies or peerDependencies? 🤔

I think it's related to how deps are listed, like I mentioned. Maybe @hjvedvik can help us out here since he probably has more experience dealing with this things than I do haha