restrict vertical resize with sizeToContent

gridstack / gridstack.js

Build interactive dashboards in minutes.

https://gridstackjs.com

MIT License

6.53k stars 1.27k forks source link

restrict vertical resize with sizeToContent #2612

Closed adumesny closed 7 months ago

adumesny commented 7 months ago

Description

since sizeToContent:true will automatically size the content vertically, don't let the user change the height to start with

Note: tried to change the feedback to have e,w arrows but we only have 10px area which is too narrow to show feedback (we have 20x20 for corners that may overlap content which is ok). Showing normal handles for now.

Checklist

[x] Created tests which fail without the change (if possible)
[ ] All tests passing (yarn test)
[ ] Extended the README / documentation, if necessary

cff3 commented 6 months ago

Hi @adumesny as far as I can see, this change prevents a user from resizing a widget vertically even if sizeToContent was set to a number instead of setting it to true. Is this intentional?

On the demo page (https://gridstackjs.com/demo/sizeToContent.html) it is still possible to resize widget E, but maybe the demo site uses an older version of grid stack? I didn't manage to understand what version is used on the demo site.

adumesny commented 6 months ago

It's a bug. Number should let you resize that's the all point. I made the tweak too fast...