search

gridstack / gridstack.js

Build interactive dashboards in minutes.
https://gridstackjs.com
MIT License
6.38k stars 1.27k forks source link

`dist` folder is missing from both repo and releases #2665

Closed BSarmady closed 3 months ago

BSarmady commented 3 months ago

Subject of the issue

dist folder is missing from both repo and releases Which neither of demos will work and Getting started section in website is invalid too.

Your environment

N/A

Steps to reproduce

N/A

Expected behavior

dist folder need to be included.

adumesny commented 3 months ago

by design as /dist require a build step. demos are live on website https://gridstackjs.com/

BSarmady commented 1 month ago

@adumesny I have seen your website and then I came here.

The Getting Started section does not mention the build step.

I'm fullstack developer but not a typescript one and never needed to use either node or npm in my web frontend projects. I don't think <script src="node_modules/gridstack/dist/gridstack-all.js"></script> emphasizing on node_modules is the way front-end people address JavaScript in their applications, well unless you are not supporting pure javascript, html, css web applications. I always put the complete library in either assets/plugin/ or assets/vendor/

the minified script that I can download from your website seems to me compiled for ES3 since it does not support any of changes made in ES6 and after.

anyway, I forked your project and will try and compile it to JS to create a valid javascript dist folder which includes a full and a minified version with map files.

Thanks again

adumesny commented 1 month ago

npm install gridstack (it is an npm package) is how you get the published dist content. it is es5 (there is also an old es3 someone created for IE but I don't maintain that)

the website is a hack using node_modules so I can reasily update when I release a new version, but maybe better way to do that...