search

griff / metaz

Two letters better than MetaX
https://metaz.maven-group.org/
MIT License
413 stars 56 forks source link

Movie/TV Show lookup Fails #202

Open tscrip opened 5 years ago

tscrip commented 5 years ago

I don't know if this project is still active, but whenever I attempt to lookup a Movie/TV Show, I get nothing returned. Looking at the log, it is attempting to use https://tagchimp.com which does not appear to respond to request.

Is there a fix for this?

agewanter commented 5 years ago

A couple of weeks ago the lookup for movies failed but the TV lookup still works

tebruno99 commented 5 years ago

I am also getting this recently.

2019-08-01 12:33:57.822 MetaZ[1117:666351] [lvl=1] -[MZOperationsController operationFinished:] Finished operation
2019-08-01 12:33:57.822 MetaZ[1117:666351] [lvl=1] -[MZOperationsController operationFinished:] Sending operationsFinished
2019-08-01 12:33:57.944 MetaZ[1117:666351] [lvl=2] -[SearchController doSearch:] Starting search 1
2019-08-01 12:33:57.944 MetaZ[1117:666351] [lvl=1] -[TheTVDBPlugin searchWithData:delegate:queue:] Sent request to TheTVDB
2019-08-01 12:33:58.285 MetaZ[1117:668138] [lvl=1] -[MZOperationsController operationFinished:] Finished operation
2019-08-01 12:33:58.285 MetaZ[1117:668138] [lvl=1] -[MZOperationsController operationFinished:] Not all finished <MZHTTPRequest: 0x7faf4e58a470>
2019-08-01 12:33:58.306 MetaZ[1117:668138] [lvl=1] -[TheTVDBSearch fetchSeriesFailed:] Request failed with status code 404
2019-08-01 12:33:58.306 MetaZ[1117:668138] [lvl=1] -[TheTVDBSearch fetchSeriesFailed:] Request failed with data <html>
jamesnewby commented 5 years ago

I've just taken a look and it looks like the tvdb api has moved to a version 2 which is a new URL and requires authentication

mystic1031 commented 5 years ago

Is this going to be able to be fixed or does it make Metaz DOA

martijnengler commented 5 years ago

Not only does it require auth, it seems like the current code (https://github.com/griff/metaz/blob/develop/Plugins/TheTVDB/src/TheTVDBSearch.m#L166) expects XML, but the new TVDB API uses JSON (https://api.thetvdb.com/swagger#!/Search/)

This probably means the whole TheTVDB plugin would need to be updated to work with the new API, and since a user/pass is now required, there's also probably some UI work that needs to be done in the preferences window.

So, I think this can be fixed (technically speaking that is), but it would probably require some serious work. I'm ~not very good~terrible at writing Objective-C, so I don't think I can really contribute anything here.

griff commented 5 years ago

It seems to have been a temporary downtime of the version 1 API. It looks to be working again.

griff commented 4 years ago

But now I have rewritten the two search plugins from scratch in Swift and am now using the newest API version for TheTVDB and have added support for getting data about TV shows from TheMovieDb