griff / metaz

Two letters better than MetaX
https://metaz.maven-group.org/
MIT License
411 stars 56 forks source link

TVDB Searches No Longer Working #228

Open Haravikk opened 4 years ago

Haravikk commented 4 years ago

As of three days ago (4th March 2020) MetaZ is no longer fetching search results from TheTVDB anymore, anyone have any idea why?

From what I can tell there's no issue with thetvdb.com site or APIs, they seem to be responding normally, I'm just not getting any search results in MetaZ, for shows that I know can return results (as I set tags for earlier episodes last week without issue).

MetaZ's log isn't showing any obvious error, it's triggering a request for the plugin, it just isn't getting a response.

Delay0845 commented 4 years ago

I'm experiencing the same thing. Everything was working fine earlier in the week, and Movies still function without issue, but TV data doesn't even return search results.

jmcintyre commented 4 years ago

TheTVDB is returning an error 401 on the final full series request. Everything else seems to be working up to that point.

jmcintyre commented 4 years ago

If you want to see the error, uncomment lines 496 and 497 from TheTVDBSearch.m

griff commented 4 years ago

Given that The TVDB plugin is down and both search plugins have a deadlock issue I have decided to release the new versions of the plugins a little early. See #229 for the changes and when that is merged a new release is automatically built and deployed.

matthew-cox commented 4 years ago

I just tested the new build (b74) and it is crashing on launch on my Mojave machine:

Process:               MetaZ [46653]
Path:                  /Applications/MetaZ.app/Contents/MacOS/MetaZ
Identifier:            org.maven-group.MetaZ
Version:               1.0.beta-74 (20.03.08.21.b9ec864)
Code Type:             X86-64 (Native)
Parent Process:        ??? [1]
Responsible:           MetaZ [46653]
User ID:               502

Date/Time:             2020-03-08 17:25:14.655 -0400
OS Version:            Mac OS X 10.14.6 (18G3020)
Report Version:        12
Anonymous UUID:        DCC3D8D5-A96B-5BE5-BB87-F9C762A9C1FD

Sleep/Wake UUID:       D7530C2F-174E-4E30-8EAE-631EFB87496F

Time Awake Since Boot: 150000 seconds
Time Since Wake:       540 seconds

System Integrity Protection: enabled

Crashed Thread:        0

Exception Type:        EXC_CRASH (SIGABRT)
Exception Codes:       0x0000000000000000, 0x0000000000000000
Exception Note:        EXC_CORPSE_NOTIFY

Termination Reason:    DYLD, [0x1] Library missing

Application Specific Information:
dyld: launch, loading dependent libraries

Dyld Error Message:
  Library not loaded: @rpath/libswiftAppKit.dylib
  Referenced from: /Applications/MetaZ.app/Contents/Frameworks/MetaZKit.framework/Versions/A/MetaZKit
  Reason: image not found

Binary Images:
       0x101484000 -        0x1014beff7 +org.maven-group.MetaZ (1.0.beta-74 - 20.03.08.21.b9ec864) <2A63F00B-7CDF-335C-80C3-EBA285DB7535> /Applications/MetaZ.app/Contents/MacOS/MetaZ
       0x101513000 -        0x10155fff7 +org.maven-group.MetaZKit (1.0.beta-74 - 20.03.08.21) <69D9FB1C-EC1F-38E0-A810-CAC1BAEAF672> /Applications/MetaZ.app/Contents/Frameworks/MetaZKit.framework/Versions/A/MetaZKit
       0x1015b0000 -        0x1015f9ff7 +org.sparkle-project.Sparkle (1.19.0 - 1.19.0) <F82900CD-E515-3377-9E1B-F90A6EFA304A> /Applications/MetaZ.app/Contents/Frameworks/Sparkle.framework/Versions/A/Sparkle
       0x106900000 -        0x10696a70f  dyld (655.1.1) <1605ACFC-49C3-33AF-B319-5BE41FC6E208> /usr/lib/dyld
    0x7fff502fc000 -     0x7fff510b1ffb  com.apple.AppKit (6.9 - 1671.60.109) <6D4ADA95-CA64-34F3-8DBD-2A53BD08D12A> /System/Library/Frameworks/AppKit.framework/Versions/C/AppKit
    0x7fff51bb8000 -     0x7fff51f5afff  com.apple.CFNetwork (978.2 - 978.2) <2D35E1BA-0579-3678-A8FB-1CF7747EE02A> /System/Library/Frameworks/CFNetwork.framework/Versions/A/CFNetwork
    0x7fff52471000 -     0x7fff52471fff  com.apple.Cocoa (6.11 - 23) <A6378C44-EE12-392C-9A2D-7BE630136A9D> /System/Library/Frameworks/Cocoa.framework/Versions/A/Cocoa
    0x7fff52ce6000 -     0x7fff5312bfef  com.apple.CoreFoundation (6.9 - 1575.23) <91D1D63A-9417-376D-801A-9ABDE4879F48> /System/Library/Frameworks/CoreFoundation.framework/Versions/A/CoreFoundation
    0x7fff5312d000 -     0x7fff537bdfe7  com.apple.CoreGraphics (2.0 - 1265.10) <499FBFEF-FB70-3F0B-9A9B-89CCE3EE3640> /System/Library/Frameworks/CoreGraphics.framework/Versions/A/CoreGraphics
    0x7fff53f3d000 -     0x7fff53f3dfff  com.apple.CoreServices (946 - 946) <DEB65571-3137-3B04-9549-22B3FE160E85> /System/Library/Frameworks/CoreServices.framework/Versions/A/CoreServices
    0x7fff54f6a000 -     0x7fff55317ffb  com.apple.Foundation (6.9 - 1575.23) <3BD6326F-5F7C-3494-B324-A4A862794AC0> /System/Library/Frameworks/Foundation.framework/Versions/C/Foundation
    0x7fff5d791000 -     0x7fff5d791fff  com.apple.quartzframework (1.5 - 23) <88AD9EA8-0A11-37A5-9239-CE2D943C4862> /System/Library/Frameworks/Quartz.framework/Versions/A/Quartz
    0x7fff5e97b000 -     0x7fff5e9e8fff  com.apple.SystemConfiguration (1.17 - 1.17) <30C8327F-3EFF-3520-9C50-016F8B6B954F> /System/Library/Frameworks/SystemConfiguration.framework/Versions/A/SystemConfiguration
    0x7fff7bc8c000 -     0x7fff7bc8dffb  libSystem.B.dylib (1252.250.1) <53C66B05-7254-344C-BC66-7BD2EE41F4E5> /usr/lib/libSystem.B.dylib
    0x7fff7c890000 -     0x7fff7c980fff  libiconv.2.dylib (51.200.6) <2047C9B7-3F74-3A95-810D-2ED8F0475A99> /usr/lib/libiconv.2.dylib
    0x7fff7d4c5000 -     0x7fff7dc4afdf  libobjc.A.dylib (756.2) <7C312627-43CB-3234-9324-4DEA92D59F50> /usr/lib/libobjc.A.dylib
    0x7fff7e335000 -     0x7fff7e347ff7  libz.1.dylib (70.200.4) <B048FC1F-058F-3A08-A1FE-81D5308CB3E6> /usr/lib/libz.1.dylib
wademaxfield commented 4 years ago

b80 doesn't have this issue.

griff commented 4 years ago

@matthew-cox yeah I had a build problem where my local builds where fine but the deployed version was missing the swift runtime libraries. As @wademaxfield said it is fixed now from version b78 and forward.

KingdomDesignsConsulting commented 2 years ago

It seems we are back to TVDB searches not working. The reason seems to be because, according to the log, the plugin is not being used to actually make the search request. Any thoughts?

Log with IMDB movie search: 2022-02-10 19:21:08.660 MetaZ[46010:717065] [lvl=2] -[SearchController doSearch:] Starting search 1 2022-02-10 19:21:08.661 MetaZ[46010:717065] [lvl=1] -[TheMovieDbPlugin searchWithData:delegate:queue:] Sent request to TheMovieDb 2022-02-10 19:21:09.004 MetaZ[46010:718114] [lvl=1] -[MZOperationsController operationFinished:] Finished operation

Log with TVDB TV search: 2022-02-10 19:22:28.871 MetaZ[46010:717065] [lvl=2] -[SearchController doSearch:] Starting search 1 2022-02-10 19:22:28.872 MetaZ[46010:717065] [lvl=1] -[SearchController finishedSearch:] Finished search 0

jdavidbuerk commented 11 months ago

Also having problems with any search results showing, mostly TV, but also movies. Files previously processed with MetaZ will show some results in the search window, but new files (never processed through MetaZ) I am unable to get any results in the search window regardless of toggling the plugins.

Haravikk commented 11 months ago

Seems to be working okay for me. What data are you entering?

I usually have to enter at least the show name and season number before I can get useful results, and TVDB in particular can be really weird about what it matches; sometimes I have to add the year in brackets after the show name, or check the show name wasn't translated from another language (for some non-english shows you have to enter the original name rather than the translated one).

jdavidbuerk commented 11 months ago

Seems to be only an issue when Video Type is set to TV Show. I've tried under v1.0.3 and now v.1.0b544. Same behavior, regardless of which TVDB plugin I have enabled; one, the other, or both. Setting type to Movie will pull results from The Movie Databases, either or both depending upon which of those plugins you have enabled.

When a file is set to TV Show, it doesn't matter what you search, no results populate. I'm trying to add metadata to episodes of Knight Rider, but I've tried other shows and movie titles including (with and without "the"): The Simpsons, CSI, Law & Order / Law and Order, The Matrix, Hitch, Office Space. Results always populate when the file is set to Movie, but it's blank when set to TV Show. The last time I used MetaZ was over a year ago, and I didn't have any issues at that point.

Set to TV Show:

Screenshot 2023-08-12 at 2 36 50 AM

Set to Movie:

Screenshot 2023-08-12 at 2 37 04 AM

My log file, showing MetaZ startup, adding a file set to TV Show, and running one single search for "knight rider":

2023-08-12 02:49:17.997 MetaZ[14248:855495] Deprecated Binding Warning: 'data' binding of class PosterView is deprecated. You will only see this warning once.
2023-08-12 02:49:18.030 MetaZ[14248:855495] [lvl=2] -[SearchController doSearch:] Starting search 1
2023-08-12 02:49:18.030 MetaZ[14248:855495] [lvl=1] -[MZPluginController loadPluginSourceWithName:fromURL:error:] Loading plugin at path '/Applications/MetaZ.app/Contents/PlugIns/Update iTunes.scptd'
2023-08-12 02:49:18.031 MetaZ[14248:855495] [lvl=1] -[MZPluginController loadPluginSourceWithName:fromURL:error:] Loading plugin at path '/Applications/MetaZ.app/Contents/PlugIns/Update TV app.scptd'
2023-08-12 02:49:18.031 MetaZ[14248:855495] [lvl=1] -[MZPluginController loadPluginSourceWithName:fromURL:error:] Loading plugin at path '/Applications/MetaZ.app/Contents/PlugIns/AlertWindow.mzactions'
2023-08-12 02:49:18.031 MetaZ[14248:855495] [lvl=1] -[MZPluginController loadPluginSourceWithName:fromURL:error:] Loading plugin at path '/Applications/MetaZ.app/Contents/PlugIns/OSXNotification.mzactions'
2023-08-12 02:49:18.031 MetaZ[14248:855495] [lvl=1] -[MZPluginController loadPluginSourceWithName:fromURL:error:] Loading plugin at path '/Applications/MetaZ.app/Contents/PlugIns/TheMovieDb.mzsearchprovider'
2023-08-12 02:49:18.031 MetaZ[14248:855495] [lvl=1] -[MZPluginController loadPluginSourceWithName:fromURL:error:] Loading plugin at path '/Applications/MetaZ.app/Contents/PlugIns/AtomicParsley.mzdataprovider'
2023-08-12 02:49:18.031 MetaZ[14248:855495] [lvl=1] -[MZPluginController loadPluginSourceWithName:fromURL:error:] Loading plugin at path '/Applications/MetaZ.app/Contents/PlugIns/Quit MetaZ.scpt'
2023-08-12 02:49:18.031 MetaZ[14248:855495] [lvl=1] -[MZPluginController loadPluginSourceWithName:fromURL:error:] Loading plugin at path '/Applications/MetaZ.app/Contents/PlugIns/TheTVDB.mzsearchprovider'
2023-08-12 02:49:18.031 MetaZ[14248:855495] [lvl=1] -[MZPluginController loadPluginSourceWithName:fromURL:error:] Loading plugin at path '/Applications/MetaZ.app/Contents/PlugIns/TheMovieDbNG.mzsearchprovider'
2023-08-12 02:49:18.031 MetaZ[14248:855495] [lvl=1] -[MZPluginController loadPluginSourceWithName:fromURL:error:] Loading plugin at path '/Applications/MetaZ.app/Contents/PlugIns/Add to iTunes.scptd'
2023-08-12 02:49:18.031 MetaZ[14248:855495] [lvl=1] -[MZPluginController loadPluginSourceWithName:fromURL:error:] Loading plugin at path '/Applications/MetaZ.app/Contents/PlugIns/Add to TV app.scptd'
2023-08-12 02:49:18.031 MetaZ[14248:855495] [lvl=1] -[MZPluginController loadPluginSourceWithName:fromURL:error:] Loading plugin at path '/Applications/MetaZ.app/Contents/PlugIns/TheTVDB3.mzsearchprovider'
2023-08-12 02:49:18.032 MetaZ[14248:855495] [lvl=2] -[MZPluginController loadPluginFromSource:error:] Maximum version 10.14
2023-08-12 02:49:18.032 MetaZ[14248:855495] [lvl=3] -[MZPluginController loadPluginFromSource:error:] Plugin Update iTunes can only run on macOS versions up to 10.14.0, but is being run on 13.5.0, and so is ignored.
2023-08-12 02:49:18.034 MetaZ[14248:855495] [lvl=2] -[MZPluginController loadPluginFromSource:error:] Minimum version 10.15
2023-08-12 02:49:18.070 MetaZ[14248:855495] [lvl=2] -[MZPluginController loadPluginFromSource:error:] Loaded plugin 'Update TV app'
2023-08-12 02:49:18.070 MetaZ[14248:855495] [lvl=2] -[MZPluginController loadPluginFromSource:error:] Minimum version 10.11
2023-08-12 02:49:18.071 MetaZ[14248:855495] [lvl=2] -[MZPluginController loadPluginFromSource:error:] Loaded plugin 'io.metaz.plugin.AlertWindow'
2023-08-12 02:49:18.072 MetaZ[14248:855495] [lvl=2] -[MZPluginController loadPluginFromSource:error:] Minimum version 10.11
2023-08-12 02:49:18.072 MetaZ[14248:855495] [lvl=2] -[MZPluginController loadPluginFromSource:error:] Loaded plugin 'io.metaz.plugin.OSXNotification'
2023-08-12 02:49:18.073 MetaZ[14248:855495] [lvl=2] -[MZPluginController loadPluginFromSource:error:] Minimum version 10.11
2023-08-12 02:49:18.073 MetaZ[14248:855495] [lvl=2] -[MZPluginController loadPluginFromSource:error:] Loaded plugin 'io.metaz.plugin.TheMovieDb'
2023-08-12 02:49:18.075 MetaZ[14248:855495] [lvl=2] -[MZPluginController loadPluginFromSource:error:] Minimum version 10.11
2023-08-12 02:49:18.075 MetaZ[14248:855495] [lvl=2] -[MZPluginController loadPluginFromSource:error:] Loaded plugin 'io.metaz.plugin.AtomicParsley'
2023-08-12 02:49:18.075 MetaZ[14248:855495] [lvl=2] -[MZPluginController loadPluginFromSource:error:] Loaded plugin 'Quit MetaZ'
2023-08-12 02:49:18.075 MetaZ[14248:855495] [lvl=2] -[MZPluginController loadPluginFromSource:error:] Disabled plugin 'Quit MetaZ'
2023-08-12 02:49:18.076 MetaZ[14248:855495] [lvl=2] -[MZPluginController loadPluginFromSource:error:] Minimum version 10.11
2023-08-12 02:49:18.077 MetaZ[14248:855495] [lvl=2] -[MZPluginController loadPluginFromSource:error:] Loaded plugin 'io.metaz.plugin.TheTVDB'
2023-08-12 02:49:18.078 MetaZ[14248:855495] [lvl=2] -[MZPluginController loadPluginFromSource:error:] Minimum version 10.11
2023-08-12 02:49:18.079 MetaZ[14248:855495] [lvl=2] -[MZPluginController loadPluginFromSource:error:] Loaded plugin 'io.metaz.plugin.TheMovieDbNG'
2023-08-12 02:49:18.079 MetaZ[14248:855495] [lvl=2] -[MZPluginController loadPluginFromSource:error:] Maximum version 10.14
2023-08-12 02:49:18.079 MetaZ[14248:855495] [lvl=3] -[MZPluginController loadPluginFromSource:error:] Plugin Add to iTunes can only run on macOS versions up to 10.14.0, but is being run on 13.5.0, and so is ignored.
2023-08-12 02:49:18.080 MetaZ[14248:855495] [lvl=2] -[MZPluginController loadPluginFromSource:error:] Minimum version 10.15
2023-08-12 02:49:18.081 MetaZ[14248:855495] [lvl=2] -[MZPluginController loadPluginFromSource:error:] Loaded plugin 'Add to TV app'
2023-08-12 02:49:18.081 MetaZ[14248:855495] [lvl=2] -[MZPluginController loadPluginFromSource:error:] Disabled plugin 'Add to TV app'
2023-08-12 02:49:18.082 MetaZ[14248:855495] [lvl=2] -[MZPluginController loadPluginFromSource:error:] Minimum version 10.11
2023-08-12 02:49:18.083 MetaZ[14248:855495] [lvl=2] -[MZPluginController loadPluginFromSource:error:] Loaded plugin 'io.metaz.plugin.TheTVDB3'
2023-08-12 02:49:18.083 MetaZ[14248:855495] [lvl=1] -[SearchController finishedSearch:] Finished search 0
2023-08-12 02:49:46.924 MetaZ[14248:855495] [lvl=1] -[MZTaskOperation startOnMainThread] Launch AtomicParsley /Volumes/LaCie 5TB/VIDEO STORAGE/SORT/Knight Rider/Season 01/DISC 1A/Knight Rider – s01e01 - Knight of the Phoenix PILOT.m4v -t
2023-08-12 02:49:46.990 MetaZ[14248:855495] [lvl=1] -[MZParseTaskOperation standardOutputGotData:] AtomicParsley stdout Atom "©nam" contains: KNIGHT_RIDER.Title1
Atom "tvsn" contains: 0
Atom "tves" contains: 0
Atom "©too" contains: DVDFab 11.0.8.6
Atom "covr" contains: 1 piece of artwork
2023-08-12 02:49:46.990 MetaZ[14248:855495] [lvl=1] -[MZOperationsController operationFinished:] Finished operation
2023-08-12 02:49:46.990 MetaZ[14248:855495] [lvl=1] -[MZOperationsController operationFinished:] Not all finished <APPictureReadDataTask: 0x120fc72e0>
2023-08-12 02:49:46.990 MetaZ[14248:855495] [lvl=1] -[MZTaskOperation startOnMainThread] Launch AtomicParsley /Volumes/LaCie 5TB/VIDEO STORAGE/SORT/Knight Rider/Season 01/DISC 1A/Knight Rider – s01e01 - Knight of the Phoenix PILOT.m4v -e /var/folders/jr/s8tbws_10b5381zlv_d5kxjm0000gn/T/MetaZImage_B46B3430-6FE5-43DB-AFC9-ABDD15A6731D-14248-000001B4E1B6860E
2023-08-12 02:49:47.026 MetaZ[14248:855495] [lvl=1] -[MZTaskOperation standardOutputGotData:] AtomicParsley stdout Extracted artwork to file: /var/folders/jr/s8tbws_10b5381zlv_d5kxjm0000gn/T/MetaZImage_B46B3430-6FE5-43DB-AFC9-ABDD15A6731D-14248-000001B4E1B6860E_artwork_1.png
No changes.
2023-08-12 02:49:47.028 MetaZ[14248:855495] [lvl=1] -[MZOperationsController operationFinished:] Finished operation
2023-08-12 02:49:47.028 MetaZ[14248:855495] [lvl=1] -[MZOperationsController operationFinished:] Not all finished <APChapterReadDataTask: 0x12082c780>
2023-08-12 02:49:47.028 MetaZ[14248:855495] [lvl=1] -[MZTaskOperation startOnMainThread] Launch mp4chaps -l /Volumes/LaCie 5TB/VIDEO STORAGE/SORT/Knight Rider/Season 01/DISC 1A/Knight Rider – s01e01 - Knight of the Phoenix PILOT.m4v
2023-08-12 02:49:47.105 MetaZ[14248:855495] [lvl=1] -[MZParseTaskOperation standardOutputGotData:] mp4chaps stdout Duration 01:35:58.762
QuickTime Chapters of "/Volumes/LaCie 5TB/VIDEO STORAGE/SORT/Knight Rider/Season 01/DISC 1A/Knight Rider – s01e01 - Knight of the Phoenix PILOT.m4v"
    Chapter #001 - 00:00:00.000 - 00:28:10.855 - "Chapter 1"
    Chapter #002 - 00:28:10.855 - 00:20:17.716 - "Chapter 2"
    Chapter #003 - 00:48:28.571 - 00:25:28.109 - "Chapter 3"
    Chapter #004 - 01:13:56.680 - 00:21:56.315 - "Chapter 4"
    Chapter #005 - 01:35:52.995 - 00:00:05.714 - "Chapter 5"
2023-08-12 02:49:47.105 MetaZ[14248:855495] [lvl=1] -[MZOperationsController operationFinished:] Finished operation
2023-08-12 02:49:47.105 MetaZ[14248:855495] [lvl=1] -[MZOperationsController operationFinished:] Sending operationsFinished
2023-08-12 02:49:50.927 MetaZ[14248:855495] [lvl=2] -[SearchController doSearch:] Starting search 1
2023-08-12 02:49:50.927 MetaZ[14248:855495] [lvl=1] -[SearchController finishedSearch:] Finished search 0
2023-08-12 02:49:54.142 MetaZ[14248:855495] [lvl=2] -[SearchController doSearch:] Starting search 1
2023-08-12 02:49:54.142 MetaZ[14248:855495] [lvl=1] -[SearchController finishedSearch:] Finished search 0
2023-08-12 02:49:54.142 MetaZ[14248:855495] [lvl=2] -[SearchController doSearch:] Starting search 1
2023-08-12 02:49:54.142 MetaZ[14248:855495] [lvl=1] -[SearchController finishedSearch:] Finished search 0
2023-08-12 02:49:56.918 MetaZ[14248:855495] [lvl=2] -[SearchController doSearch:] Starting search 1
2023-08-12 02:49:56.918 MetaZ[14248:855495] [lvl=1] -[SearchController finishedSearch:] Finished search 0
dagronf commented 11 months ago

As @Haravikk mentioned, for tv shows you need to enter a show name, series number and episode number on the 'Video' tab in order for the search to work for tv series.

To test this using your data, I renamed a file to 'Knight Rider - s01e01 - Knight of the Phoenix PILOT.m4v', imported it into MetaZ (Version 1.0.3 (22.0426.2138.8e64083)),

The search then worked as expected. (see screenshot)

Screenshot 2023-08-12 at 7 16 53 pm Screenshot 2023-08-12 at 7 21 15 pm Screenshot 2023-08-12 at 7 22 22 pm
jdavidbuerk commented 11 months ago

Thanks for the input; inputting the Show title, Season Number, and Episode Number did indeed start populating results finally; I don't remember having to do that before, and had been trying entering that info in the main search bar and as demonstrated by my network monitor it never even began reaching out to TVDB until I filled in those fields in the Video tab. I was successfully able to process all seasons of Knight Rider and a few others I had sitting waiting to sort.

I guess it's been longer since I've processed a TV Series in MetaZ than I thought. Oops!