search

griff / metaz

Two letters better than MetaX
https://metaz.maven-group.org/
MIT License
411 stars 56 forks source link

Manually copy sparkle #234

Closed jmcintyre closed 4 years ago

jmcintyre commented 4 years ago

This changes the build process to only use Carthage to create the Sparkle framework. The framework is copied into place by configuration in Xcode. This fixes a signing issues when building in Xcode 11. Also, Sparkle was updated.

jmcintyre commented 4 years ago

If you combine this pull request with the sign-applescript branch, Xcode 11 now builds in release for me.

jmcintyre commented 4 years ago

I need to remove some debug flags before this can be merged in. It now requires Xcode 11 (or a newer git manually installed).

jmcintyre commented 4 years ago

Should be cleaned up now.

griff commented 4 years ago

@jmcintyre I am not getting any errors when building the current develop branch with Xcode 11. I even made a fresh git clone and built the project from scratch and still no build problem.

But if this fixes your build that is more important.

jmcintyre commented 4 years ago

Were you building release? The problem seems to happen only in release and both for me here, but also on Travis CI.

griff commented 4 years ago

I tested both with release builds on my local Catalina VM and I believe I also tested Travis

griff commented 4 years ago

The thing that made the build work on development builds and break on release builds was that COPY_PHASE_STRIP was only set to YES for Release builds and that is what triggered the bug in Carthage.

jmcintyre commented 4 years ago

I'll try the older checkin again. If we can revert these changes that would be better.