alter_SSID should prompt for user input

griffey / LibraryBox

Fork of PirateBox designed for educational and library use.

64 stars 15 forks source link

alter_SSID should prompt for user input #6

Closed thatandromeda closed 11 years ago

thatandromeda commented 11 years ago

Notes:

scanned for vulnerabilities now that I'm prompting for user input; internet did not scream any forth at me, but use your own judgment
what version of Python are you building against? in 3.x the raw_input() function is replaced by input() (but in 2.x you should definitely use raw_input(), not the different and more dangerous input()).

MaStr commented 11 years ago

Hi, I'm not very happy with the python solution, because changing SSID can be done with OpenWRT's uci command:

uci set "wireless.@wifi-iface[0].ssid=My nice network name" uci commit (and a reboot or reload of network stuff)

So why create an additional soltion for this?!

Matthias

griffey commented 11 years ago

Matthias: originally it was because the text-based python solution was transparently easy to do, even for those of us without the understanding of the deeper mysteries of OpenWRT.

Does the uci command change the textfile that has the SSID in it? Or does it override it? My goal with the above was to have a script that prompted for user input re: SSID name...so a python script is still an option, just using the uci command with that variable. Yes?

MaStr commented 11 years ago

it changes the /etc/config/wireless file, yes.

griffey commented 11 years ago

Ok then. I'll kill this particular pull request, and revisit just using the uci command. Unless you want to do it. :-)

I may do it on a branch initially, just for testing. I'm still figuring out git.