search

griffithlab / GenVisR

Genome data visualizations
Creative Commons Zero v1.0 Universal
209 stars 62 forks source link

Make segment color in cnView configurable #307

Closed lbeltrame closed 7 years ago

lbeltrame commented 7 years ago

The green tint used when overlaying segments on the log2ratio / copy number data isn't too pretty to show in a publication. Instead of hardcoding, the colour option used in cnView_buildMain could get a parameter passed to it (segmentColor?).

I can look into it, but I'd like a suggestion on the parameter name (API naming isn't my best).

zlskidmore commented 7 years ago

@lbeltrame segementColor sounds good to me!

You might be able to do this in a round about way by passing another geom_segment() layer through the plotLayer param. but that would be some work for the user so probably best just to make another param.