search

griffithlab / civic-client

Web client for CIViC: Clinical Interpretations of Variants in Cancer
MIT License
50 stars 28 forks source link

suggested changes attributes need to be translated from db format to client display format #1156

Open kkrysiak opened 5 years ago

kkrysiak commented 5 years ago

phenotype_id and drug_id are less clear than I think is intended (Drug ID = drug name)

Forcing the "_" can be confusing for 2 word items like representative coordinate (although this should be pretty obvious given you can see it).

jmcmichael commented 4 years ago

Suggested revision diffs and advanced search results grid shows ugly database field names, e.g. 'drug_interaction_type', 'representative_transcript'. Instead they should show labels used in the rest of the interface, e.g. 'Drug Interaction Type', 'Representative Transcript'. I'll need to create a hash to look these up when they need to be translated for display.