griffithlab / civic-client

Web client for CIViC: Clinical Interpretations of Variants in Cancer
MIT License
50 stars 28 forks source link

Add link to ProteinPaint CIViC track in CIViC gene summary #1258

Closed malachig closed 4 years ago

malachig commented 4 years ago

We are working with ProteinPaint to have gene and variant level cross linking. After preliminary discussion with Dr. Zhang and members of her team the following action items were proposed:

  1. ProteinPaint would pull in monthly CIViC releases and create a CIViC "track" within ProteinPaint similar to what is currently done for ClinVar or Cosmic. CIViC data releases can be found here: https://civicdb.org/releases
  2. CIViC would create a Gene-level link to ProteinPaint (we should confirm with them how this is named and whether to use a logo they approve of). This link would for example take the user from CIViC BRAF page to ProteinPaint BRAF page. The URL would be crafted so that by default the CIViC track would be loaded in ProteinPaint and perhaps some other defaults (e.g. pediatric mutations, or COSMIC?, or ClinVar?). In the CIViC page, this could look similar to how we currently link to DGIdb at the gene level.
  3. ProteinPaint would create a Gene-level link back to CIViC. Examples for creating these links can be found here: https://griffithlab.github.io/civic-api-docs/#linking
  4. The ProteinPaint CIViC track would link individual variants back to the corresponding variant page in CIViC. Examples for creating these links can be found here: https://griffithlab.github.io/civic-api-docs/#linking
  5. CIViC variant records would link to ProteinPaint pages so that when the user arrives at ProteinPaint, the variant is already selected/highlighted in ProteinPaint. This may require some further discussion with ProteinPaint developers to figure out how to identify the variant correctly. In the CIViC page the variant link to ProteinPaint could look like what we do for Allele Registry ID.

Other notes:

susannasiebert commented 4 years ago

For 1. I would recommend CIViCpy over parsing our TSVs.

For 4. and 5. we would need to figure out how to associate their variants with ours. I would recommend using the ClinGen Allele Registry as an in between since users are already able to look up CIViC variants by CAID.

arpaddanos commented 4 years ago

I would suggest that representation of CIViC EIDs in ProteinPaint be restricted to accepted status. some details like if an EID has is flagged might also be taken into account, but the main issue would be restricting to accepted.

susannasiebert commented 4 years ago

If we want to do this we should instruct Xin to import/parse the accepted VCF instead of the accepted and submitted one.

malachig commented 4 years ago

Hmmm, right now you won't see too much detail about the evidence associated with each variant until you follow the link which takes you back to CIViC. There you would see the status and warnings.

Since we are not conveying any claims about the evidence in ProteinPaint maybe this is okay.

Our current default view of variants when you go to a gene in CIViC is "Show variants with accepted and/or submitted evidence".

I think we should mirror that behavior otherwise it will be confusing as one goes back and forth between a gene view in CIViC and gene view in ProteinPaint.

I also like this approach because it conveys all the variants that CIViC has some info on, but you go back to CIViC for the full details.

susannasiebert commented 4 years ago

The statuses are being outputted in the CSQ field so if they aren’t currently being displayed in protein paint it would be easy to add.

arpaddanos commented 4 years ago

It seems that if the links are at the variant level then there should be no problem.