search

griffithlab / civic-client

Web client for CIViC: Clinical Interpretations of Variants in Cancer
MIT License
50 stars 28 forks source link

@ in evidence item hyperlinks to email #1561

Closed lsheta closed 3 years ago

lsheta commented 3 years ago

See this EID

It looks like when @ is part of the text of an EID, a hyperlink is created.

acoffman commented 3 years ago

@jmcmichael, I poked around server side and it looks like the only place we do any markup preprocessing is for user comments, and the API response for the evidence description doesn't include the mailto link either, is this something happening on the angular side of things?

jmcmichael commented 3 years ago

Yeah, the evidence summary template runs the item's description text through AngularJS's 'linky' filter, which identifies that gene name with an @ symbol as an email address and creates a link out of it.

I think we apply that filter in order to support the inclusion of working URLs in these descriptions. Do we still want to support that, or was that an early feature that we can abandon? The API to that filter doesn't allow me to easily instruct it to abandon attempts to link email addresses.