search

griffithlab / civic-client

Web client for CIViC: Clinical Interpretations of Variants in Cancer
MIT License
50 stars 28 forks source link

Add Oncogenic Clinical Significance #1562

Closed susannasiebert closed 3 years ago

susannasiebert commented 3 years ago

Closes #1455

Requires https://github.com/griffithlab/civic-server/pull/664

This PR is still a work in progress. It adds the new "Oncogenic" option to the advanced search, dropdowns, add and edit forms etc. However, we still need to implement the following constraints in the add/edit evidence form:

For Functional evidence, if a user selects Oncogenic then selecting a Disease is required. However, if they pick one of the other clinical significance values Disease must be empty (the form field should be hidden).

susannasiebert commented 3 years ago

We also need to change the display in the summaries to not show the disease field for these types of evidence items.

susannasiebert commented 3 years ago

Closing in favor of #1570