search

griffithlab / civic-client

Web client for CIViC: Clinical Interpretations of Variants in Cancer
MIT License
50 stars 28 forks source link

implements logic for add/edit & display of functional oncogenic evidence #1570

Closed jmcmichael closed 3 years ago

jmcmichael commented 3 years ago

Closes #1455, requires griffithlab/civic-server#664, and includes all commits from PR #1562.

This PR updates Add & Edit Evidence forms, and Evidence summaries to hide disease fields for Functional evidence types with non-oncogenic clinical significance.

I also updated the order of the fields on the Add and Edit Evidence forms, as fields which effect the display or values of other fields should appear before the fields they effect. Therefore, Evidence Type and Clinical Significance fields appear above the Disease fields instead of below:

Screen Shot 2020-12-14 at 17 39 55
jmcmichael commented 3 years ago

A dev note: ideally these updates should have been added to @susannasiebert's PR #1562. I started work on the form functions on a new branch out of habit, and instead of merging my work with her oncogenic branch, I just pulled those commits over to my new branch, so the dual branches for the same feature is just b/c of my laziness.