griffithlab / civic-client

Web client for CIViC: Clinical Interpretations of Variants in Cancer
MIT License
50 stars 28 forks source link

the Pubmed ID text field reads DOI format ID inappropriately but never cause error messages #781

Open juheon opened 7 years ago

juheon commented 7 years ago

On the "Suggest Source" page, if I typed DOI (Digital Object Identifier) in the Pubmed ID text field, the CIViC client reads until the first non-number character and uses the truncated number as Pubmed ID. If there is any paper that matches with the truncated DOI, the Citation text field shows corresponding paper information and the Submit button works well without any error messages. For example, the paper of Benson et al., 2013, Nucleic Acids Res. has

If you use DOI ID, the CIViC client reads it as Pubmed ID: 10 and returns Schmoldt et al., 1975, Biochem. Pharmacol. This error is hard to be recognized by users.

I heard that all evidence in CIViC should have Pubmed ID. We can easily solve this issue by making the Pubmed ID text field as a numeric type. Or, if we consider using a various format of paper IDs, we can use DOI converter API (https://www.ncbi.nlm.nih.gov/pmc/pmctopmid/) and convert the input into the Pubmed ID. In this case, if there is no Pubmed ID, we can restrict the submission of a source suggestion.

It would be helpful for me to learn more about expected user experiences for Source Suggestion page. If you have any opinion, please share with me.