griffithlab / civic-client

Web client for CIViC: Clinical Interpretations of Variants in Cancer
MIT License
50 stars 28 forks source link

Add Associated Phenotypes field to evidence records #789

Closed malachig closed 6 years ago

malachig commented 7 years ago

It has been suggested that we should allow curation of associated phenotypes in addition to diseases. For example, for many VHL variants the appropriate disease is Von-Hippel Lindau but there is value to being to further specific which phenotypes are observed in each patient within this syndrome (e.g. pheochromocytoma, renal cell carcinoma, hemangioblastoma of the CNS, etc.).

It has been suggested that we use HPO terms for this purpose similarly to how we use DO terms for the disease.

malachig commented 7 years ago

Other alternatives to HPO, are UMLS and SNOMED. Others we should consider?

malachig commented 7 years ago

On the licensing issue:

malachig commented 7 years ago

Another option that has been recommended to us several times is NCI Thesaurus. It is released as Public Domain open content license.

malachig commented 6 years ago

HPO appears to have periodic stable releases: http://human-phenotype-ontology.github.io/ http://human-phenotype-ontology.github.io/downloads.html

malachig commented 6 years ago

It might be nice to support both HPO and NCI thesaurus.

susannasiebert commented 6 years ago

We didn't really get a chance to talk about this further during the meeting. Are phenotypes something we want to add evidence items or to assertions? Or to both?

malachig commented 6 years ago

Good question. I think to both

kkrysiak commented 6 years ago

Let's go with HPO for now as well.

kkrysiak commented 6 years ago

I think we decided to require an HPO term to first be added using an HPO ID, pulling that from their API. Only HPO IDs that have been added will be in the type ahead search for text. This reduces the crazy number of options in the type ahead search.

arpaddanos commented 6 years ago

It looks like we could use these to create EIDs for brain metastases: http://compbio.charite.de/hpoweb/showterm?id=HP:0030692

Choose say NSCLC from DOID and then the above from HPO.

kkrysiak commented 6 years ago

When we provide the message that people should identify an HPO term, they should be directed to the following URL. I find the home page non-intuitive and would rather direct them immediately to the term browser that is relevant. http://www.human-phenotype-ontology.org/hpoweb?id=HP:0000118

@arpaddanos I'm not sure I agree with that approach but we should definitely discuss that in our next CIViC meeting.

malachig commented 6 years ago

HPO is now integrated! Great job all. Closing this issue.