Direct object comparison always fails, use id instead

griffithlab / civic-server

Backend Server for CIViC Project

MIT License

39 stars 32 forks source link

Direct object comparison always fails, use id instead #634

Closed susannasiebert closed 4 years ago

susannasiebert commented 4 years ago

Apparently the target_user and the current_user have different object_ids so the direct comparison always fails. Comparing by id does the trick.

coveralls commented 4 years ago

Pull Request Test Coverage Report for Build 2495

4 of 5 (80.0%) changed or added relevant lines in 3 files are covered.
No unchanged relevant lines lost coverage.
Overall coverage increased (+0.05%) to 89.753%

Changes Missing Coverage	Covered Lines	Changed/Added Lines	%
app/policies/comment_policy.rb	0	1	0.0%
<!--	Total:	4	5	80.0%	-->

Totals
Change from base Build 2486:	0.05%
Covered Lines:	2111
Relevant Lines:	2352

griffithlab / civic-server

Direct object comparison always fails, use id instead #634

Pull Request Test Coverage Report for Build 2495

💛 - Coveralls