coveralls
commented
3 years ago Pull Request Test Coverage Report for Build 699569920
- 0 of 14 (0.0%) changed or added relevant lines in 1 file are covered.
- 34 unchanged lines in 22 files lost coverage.
- Overall coverage decreased (-0.01%) to 15.949%
| Changes Missing Coverage | Covered Lines | Changed/Added Lines | % | ||
|---|---|---|---|---|---|
| app/models/advanced_searches/variant.rb | 0 | 14 | 0.0% | ||
| <!-- | Total: | 0 | 14 | 0.0% | --> |
| Files with Coverage Reduction | New Missed Lines | % | ||
|---|---|---|---|---|
| app/controllers/genes_controller.rb | 1 | 83.54% | ||
| app/models/comment.rb | 1 | 63.64% | ||
| app/models/concerns/moderated.rb | 1 | 74.24% | ||
| app/models/concerns/with_countable_enum.rb | 1 | 90.0% | ||
| app/models/disease.rb | 1 | 69.23% | ||
| app/models/drug.rb | 1 | 56.25% | ||
| app/models/evidence_item.rb | 1 | 81.63% | ||
| app/models/gene.rb | 1 | 84.21% | ||
| app/models/notification.rb | 1 | 62.5% | ||
| app/models/on_site_subscription.rb | 1 | 40.0% | ||
| <!-- | Total: | 34 | --> |
| Totals | |
|---|---|
| Change from base Build 699436555: | -0.01% |
| Covered Lines: | 2130 |
| Relevant Lines: | 13355 |
In some cases, placing the conditional in a HAVING clause and grouping was not having the desired effect. This is more straightforward to reason about (and also works consistently).
Note that the view is already scoped to only include non-deleted EIDs so the behavior there will remain the same despite the removal of the previous where clause.