coveralls
commented
3 years ago Pull Request Test Coverage Report for Build 915617750
- 0 of 13 (0.0%) changed or added relevant lines in 2 files are covered.
- 3 unchanged lines in 3 files lost coverage.
- Overall coverage decreased (-0.01%) to 15.916%
| Changes Missing Coverage | Covered Lines | Changed/Added Lines | % | ||
|---|---|---|---|---|---|
| app/models/user_adaptors/orcid.rb | 0 | 2 | 0.0% | ||
| app/api_helpers/orcid_api.rb | 0 | 11 | 0.0% | ||
| <!-- | Total: | 0 | 13 | 0.0% | --> |
| Files with Coverage Reduction | New Missed Lines | % | ||
|---|---|---|---|---|
| app/api_helpers/orcid_api.rb | 1 | 0% | ||
| app/models/assertion.rb | 1 | 69.89% | ||
| app/models/variant_group.rb | 1 | 62.07% | ||
| <!-- | Total: | 3 | --> |
| Totals | |
|---|---|
| Change from base Build 861915238: | -0.01% |
| Covered Lines: | 2130 |
| Relevant Lines: | 13383 |
Something seems to have changed in their API responses. This field was previously always present but in some cases it no longer is.
In the case when we have no family or given name, we'll fall back on the orcid itself as a new user's name.