griffithlab / civic-v2

CIViC is an open access, open source, community-driven web resource for Clinical Interpretation of Variants in Cancer
https://civicdb.org
MIT License
19 stars 5 forks source link

activity feed could use gene/variant context #461

Open malachig opened 2 years ago

malachig commented 2 years ago

In civic v1, always shows the gene/variant names.

In the V2 curation timeline: https://civicdb.org/curation/activity/curation-timeline

We only see the event type and the entity IDs. Browsing through its hard to find my recent activity, whereas if the variant and gene name were shown I could more readily parse through the recent activity.

susannasiebert commented 2 years ago

I'm not quite sure I understand what you are seeing. When I go to the curation feed, it shows the variant names for me.

Screen Shot 2022-04-15 at 8 46 32 AM

Are you requesting for the variant tags to include the gene name in addition to the variant name?

malachig commented 2 years ago

Yeah, somehow I was not seeing that variant info. But it would be good to have the gene as well as in V1. To help with generic variant names like "mutation", "over-expression", etc.

susannasiebert commented 2 years ago

Do you think we should include the gene name in all variant tags, irregardless of context? Or is that just an issue in the activity feed?

susannasiebert commented 2 years ago

Also, you might've been looking at the event feed for a specific gene/variant/other entity. We disable these "affected entity" tags in this context since you are already on the affected gene/variant/etc page. E.g. https://civicdb.org/variants/12/events. If this is confusing, we can put them back.

susannasiebert commented 2 years ago

Update from 4/21 meeting: We should investigate adding the gene & variant tags to the evidence & assertion tags for subjects/originating objects. This might not be easily possible/performant with our current queries.