search

griffithlab / civicpy

A python interface for the CIViC db application
MIT License
9 stars 5 forks source link

Make official v2 release + gh action for docker image #131

Closed korikuzma closed 2 years ago

korikuzma commented 2 years ago

@acoffman and @susannasiebert agreed that we should just make the official v2 release and release molecular profiles separately

Note: This assumes the GH release tag does not include the v prefix. For instance, use 1.0.0 rather than v1.0.1

korikuzma commented 2 years ago

Added work for creating docker images. I didn't pin a version in the Dockerfile. Wasn't sure the best way to handle this. I can revert back to manually changing or think of an alternate way without having to change the version in 2 places.

I think we'll also want to set the dockerhub secrets in the repo to use the griffithlab user or a different user?

susannasiebert commented 2 years ago

Added work for creating docker images. I didn't pin a version in the Dockerfile. Wasn't sure the best way to handle this. I can revert back to manually changing or think of an alternate way without having to change the version in 2 places.

I think this is fine although we should monitor this in practice. Sometimes pypi's registry gets backed up and even though a new release is live, pip isn't aware of the new version so an old version would get installed/released in the Docker image.

I think we'll also want to set the dockerhub secrets in the repo to use the griffithlab user or a different user?

That is a good question. I haven't set up a github action for this before so I'm not entirely sure. Let me ask some of my colleagues who might have more info.

korikuzma commented 2 years ago

I think this is fine although we should monitor this in practice. Sometimes pypi's registry gets backed up and even though a new release is live, pip isn't aware of the new version so an old version would get installed/released in the Docker image.

@susannasiebert I can see if there's a way to check that the version exists before starting docker build action.