search

griffithlab / civicpy

A python interface for the CIViC db application
MIT License
9 stars 5 forks source link

feat: include molecular profile segment data in molecular profile response #144

Closed korikuzma closed 7 months ago

korikuzma commented 1 year ago

close #143 . This is needed for this hackathon issue.

@susannasiebert I can't remember how the test_cache.pkl is populated for the tests. I ran civicpy update --hard and used this as my cache. The molecular profile tests had 6353 as an ID. I tried using the graphiql api and looked at https://civicdb.org/molecular-profiles/6353/summary , but the molecular profile does not exist. 3 of the tests are failing (on both my cache with changes from my branch and the cache from the master branch). Depending on how the test_cache.pkl is populated, I can update in a separate issue.

susannasiebert commented 10 months ago

From what I remember, you did the right thing for creating the test cache pkl file. I think when I made these updates, I created a pkl from my local database since the changes weren't actually deployed yet and the ID I used in the tests would've been one from my local database and it was possibly a molecular profile that I created manually. You did the right thing by updating the ID and tests to something that matches a molecular profile in production.