griffithlab / pVACtools

http://www.pvactools.org
BSD 3-Clause Clear License
131 stars 58 forks source link

pVACseq: Discrepancy between {sample_id}.all_epitopes.tsv and {sample_id}.fasta ? #1118

Open yiolino opened 3 weeks ago

yiolino commented 3 weeks ago

Hi, thank you for developing such an excellent software.

pVACseq: Discrepancy between {sample_id}.all_epitopes.tsv and {sample_id}.fasta ?

Description

I have successfully run pVACseq without any errors.
However, I have observed that certain peptides listed in the {sample_id}.all_epitopes.tsv are not present in the {sample_id}.fasta .

Expected Behavior

I expected that all peptides listed in the {sample_id}.all_epitopes.tsv would be included in the {sample_id}.fasta.

Actual Behavior

Certain peptides present in the {sample_id}.all_epitopes.tsv are missing from the {sample_id}.fasta.

Questions

  1. Is it expected behavior that not all peptides listed in the {sample_id}.all_epitopes.tsv file are included in the {sample_id}.fasta?
  2. If this is expected, could you please explain the logic behind this behavior? I am particularly interested in the section of the code in generate_protein_fasta.py here. Is my assumption correct that this part of the code is related to the observed behavior?

Additional Information

susannasiebert commented 3 weeks ago

This is generally not expected. Would you be able to share your input VCF with us for further investigation? A VCF file with just the variant in question would be sufficient for us to be able to investigate this on our end.

yiolino commented 5 days ago

@susannasiebert Sorry for the late reply. I have created a VCF with unnecessary information masked. I have sent it to you via email. Please check it.