griffithlab / pVACtools

http://www.pvactools.org
BSD 3-Clause Clear License
141 stars 59 forks source link

Rework cleavage site predictions #615

Closed susannasiebert closed 3 years ago

susannasiebert commented 3 years ago

Right now cleavage sites are calculated on a per-eptiope basis. However, this doesn't give accurate results.

Cleavage predictions depend on sequence context (flanking amino acids). It appears that the predictions are only stable if a flanking region of 10 amino acids is added on either side of the peptide (this number should be double checked).

We should update the code to create a netchop-specific fasta (with 10 aa flanking length) and feed that to the algorithm. Subsequent calculations on the netchop result should only happen on the amino acids for the epitope of interest.

worker000000 commented 3 years ago

Right now cleavage sites are calculated on a per-eptiope basis. However, this doesn't give accurate results.

Cleavage predictions depend on sequence context (flanking amino acids). It appears that the predictions are only stable if a flanking region of 10 amino acids is added on either side of the peptide (this number should be double checked).

We should update the code to create a netchop-specific fasta (with 10 aa flanking length) and feed that to the algorithm. Subsequent calculations on the netchop result should only happen on the amino acids for the epitope of interest.

thanks a lot do you here mean the following options is not good to use? image
if use --net-chop-method, can just add --net-chop-method cterm,20s --netmhc-stab True --net-chop-threshold 0.5

. is this right?

susannasiebert commented 3 years ago

It will still be informative to run NetChop with the current implementation but you just need to be aware that the output in the report will not be comprehensive and you will need to do some additional manual analysis downstream.

You cannot run --net-chop-method cterm,20s. You need to pick one method or the other so either --net-chop-method cterm or --net-chop-method 20s.