Added more swag (Fix #1)

[joker314]

Fixes #1

I added:

• Background colour that loosely matches your icon colour
• Favicon of your profile picture (hosted on the GitHub profile servers) You already have a favicon
• That same logo image into your website
• Links to your Scratch, Github profiles
• Link to your other (main) website (all links open in new tab)
• Center everything and make clicked links still blue

[joker314]

By the way, if you wanted to, I could make the links grow when you hover over them. I have already made a mock-up. It would just require a a:hover which would set the font-size to 110% and a line-height: 110% in p, h1 elements to allow it to grow without disturbing your logo below. To be honest, I don't actually like the effect. Perhaps something like a colour change animation would be best?

[coke11]

@joker314 that would be pretty cool!

[joker314]

@coke11 What, a colour change animation or the growth?

[coke11]

All

[joker314]

Hmm, @griffpatch is there anything you'd like to say?

[griffpatch]

Hey guys :) - I'm really sorry to say I haven't even had a chance to look at what you have done yet! Its been a very hectic time for me and I wanted to see it before I commented! But since you asked here I am... I did mean at some point to make a better Web page for myself of course, but I appreciate what you have been doing for me so thank you. I will try to take a look soon.

On 2 Aug 2016 18:16, "J" notifications@github.com wrote:

Hmm, @griffpatch https://github.com/griffpatch is there anything you'd like to say?

— You are receiving this because you were mentioned.

Reply to this email directly, view it on GitHub https://github.com/griffpatch/griffpatch.github.io/pull/2#issuecomment-236972991, or mute the thread https://github.com/notifications/unsubscribe-auth/AGbNvpmFFDmX64C_uaOc_XHlyFduul4xks5qb3nRgaJpZM4JOM6a .

[joker314]

That's absolutely fine! :)

[joker314]

I'll add some more stuff if I have time :)

I think that a border might look lice, and maybe one of those outline type things that you get when uing the <fieldset> tag. Well, I'll experiment tomorrow :)

[joker314]

I found a really cool effect: transition: 0.5s; and then use the pseudo-selector ELEMENT:hover, and change its colour. For example, to make the links look cool:

a{
  transition:  0.5s;
  color: blue;
}
a:hover{
  color: green;
}

[joker314]

Well, it has been a while, I'll try and work on it some more. :)

[joker314]

Question: if somebody other than you were to click that link for unsubscribing (in your email response), wouldn't the token within the URI also work for other people, so we could unsubscribe you from here?

[griffpatch]

I suspect you would need a web browser cookie recording a logged in session on my github account :)

On 10 October 2016 at 20:44, joker314 notifications@github.com wrote:

Question: if somebody other than you were to click that link for unsubscribing (in your email response), wouldn't the token within the URI also work for other people, so we could unsubscribe you from here?

— You are receiving this because you were mentioned. Reply to this email directly, view it on GitHub https://github.com/griffpatch/griffpatch.github.io/pull/2#issuecomment-252727348, or mute the thread https://github.com/notifications/unsubscribe-auth/AGbNvgxbfygjo2AYddZ4osG05U7_Vi0Eks5qypWXgaJpZM4JOM6a .

[joker314]

Ohh that makes sense :)

So, no hurry, but if you would like to give some feedback about the PR then please, do let me know.

[coke11]

@joker314 Whoops! That unsubscribe link isn't valid for your account.

[joker314]

Sir, I am going to close this issue now, and I'll make a new one with cooler stuff in it.

Incidentally, do you mind the comment spam on your profile?

[joker314]

Ha I never did close this. Friendly reminder if you've forgotten about this PR; however, I will attempt to improve on this

[TheAwesome98-Real]

Sir, I am going to close this issue now, and I'll make a new one with cooler stuff in it.

you know you can update PRs right