search

griimick / vscode-vhs

Visual Studio Code extension providing syntax support for VHS .tape files.
https://marketplace.visualstudio.com/items/griimick.vhs
MIT License
16 stars 2 forks source link

fix: allow units to be floating point numbers #6

Closed uncenter closed 1 year ago

uncenter commented 1 year ago

Unit numbers should allow floating point numbers, ex: Sleep 2.5s. I also went ahead add removed the second numbers pattern because I'm pretty sure it is unnecessary - the first one covers everything already. I'm not too familiar with TextMate grammars though so if this is required I can undo that change.

griimick commented 1 year ago

You are right. Thanks for the contribution :)

uncenter commented 1 year ago

I just wrote out paragraphs more reasoning for the changes but thank you for merging it so quickly 😭

uncenter commented 1 year ago

@griimick Any chance we can get a new release for this?

griimick commented 1 year ago

@griimick Any chance we can get a new release for this?

done