grijjy / GrijjyCloudLogger

GrijjyCloudLogger, remote logging for Windows, iOS, Android, macOS and Linux
Other
108 stars 29 forks source link

Is GrijjyCloudLogging ready for Rx10.4 Sydney, supporting CMR ? #9

Closed Rollo62 closed 4 years ago

Rollo62 commented 4 years ago

Hi there,

I'm just checking with the latest version 10.4 and Patch 3, but find compile errors here:


`{ Sends a message to the specified service, with optional userdefined and data }
procedure TgoCloudLogger.Send(const AService: String; const AMsg: String;
  const ALevel, ADataFormat: Integer; const AData: TBytes);
var
  Msg: PZMessage;
  Protocol: TgoLogMessageProtocol;
begin
  Msg := TZMessage.Create;
  try
    Protocol.MessageText := AMsg;
    Protocol.Level := ALevel;
    Protocol.ProcessId := FProcessId;
    Protocol.ThreadId := TThread.CurrentThread.ThreadID;
    Protocol.AppName := FAppName;
    Protocol.TimeStamp := Now;
    Protocol.DataFormat := ADataFormat;
    Protocol.Data := AData;
    Msg.PushProtocolBuffer<TgoLogMessageProtocol>(Protocol); //<== [DCC Error] Grijjy.CloudLogging.Protocol.pas(253): E2512 Type parameter 'T' must be a non-nullable value type

    if (AService = '') then
      inherited Send(GrijjyLog.Service, Msg)
    else
      inherited Send(AService, Msg);
  finally
    Msg.Free;
  end;
end;

This leads me to the question if the cloud logger is updated already to be compatible with the latest version ?

allendrennan commented 4 years ago

Hello,

I believe this relates to a bug in the latest patches for 10.4 of Delphi that we are hoping that Embarcadero fixes before we have to modify a lot of our source code. We haven’t updated to Patch 2 or 3 internally because of it.

It has impacted other Delphi libraries as well. It is the most voted for, recent QC issue as well: https://quality.embarcadero.com/browse/RSP-30078

Regards, Allen

From: Rollo62 notifications@github.com Sent: Monday, August 3, 2020 11:43 PM To: grijjy/GrijjyCloudLogger GrijjyCloudLogger@noreply.github.com Cc: Subscribed subscribed@noreply.github.com Subject: [grijjy/GrijjyCloudLogger] Is GrijjyCloudLogging ready for Rx10.4 Sydney, supporting CMR ? (#9)

Hi there,

I'm just checking with the latest version 10.4 and Patch 3, but find compile errors here: `{ Sends a message to the specified service, with optional userdefined and data } procedure TgoCloudLogger.Send(const AService: String; const AMsg: String; const ALevel, ADataFormat: Integer; const AData: TBytes); var Msg: PZMessage; Protocol: TgoLogMessageProtocol; begin Msg := TZMessage.Create; try Protocol.MessageText := AMsg; Protocol.Level := ALevel; Protocol.ProcessId := FProcessId; Protocol.ThreadId := TThread.CurrentThread.ThreadID; Protocol.AppName := FAppName; Protocol.TimeStamp := Now; Protocol.DataFormat := ADataFormat; Protocol.Data := AData; Msg.PushProtocolBuffer(Protocol); //<== [DCC Error] Grijjy.CloudLogging.Protocol.pas(253): E2512 Type parameter 'T' must be a non-nullable value type

if (AService = '') then

inherited Send(GrijjyLog.Service, Msg)

else

inherited Send(AService, Msg);

finally Msg.Free; end; end; ` This leads me to the question if the cloud logger is updated already to be compatible with the latest version ?

— You are receiving this because you are subscribed to this thread. Reply to this email directly, view it on GitHubhttps://github.com/grijjy/GrijjyCloudLogger/issues/9, or unsubscribehttps://github.com/notifications/unsubscribe-auth/ACFXDCYKLSNACWL4ZKXA3C3R66UYPANCNFSM4PUCAROQ.

Rollo62 commented 4 years ago

Thanks