fix: getRequestUrl for cases with a list of sort objects

grikomsn / airtable-deno

Unofficial Airtable client for Deno 🦕

https://deno.land/x/airtable

MIT License

16 stars 8 forks source link

fix: getRequestUrl for cases with a list of sort objects #8

Closed kitcat-dev closed 8 months ago

kitcat-dev commented 3 years ago

Hello.

As mentioned in the https://github.com/grikomsn/airtable-deno/issues/7, I made some changes to the function getRequestUrl in airtable.ts. I also moved the sort type to the SortSelectOption interface and wrote a couple of tests.

Please write your opinion. I can change anything that doesn't fit with your vision of the library :)

grikomsn commented 3 years ago

Neat! Remind me to check on it this weekend. Need to upgrade my Deno runtime on my workstation and test this. 😄

kitcat-dev commented 3 years ago

No problem. I can remind you in a couple of days.

kitcat-dev commented 3 years ago

@grikomsn Hello 👋 Could you take a look at this PR? :-)

lino-levan commented 2 years ago

@grikomsn Any update?

isaced commented 1 year ago

@grikomsn Hello buddy, it works, can you merge this PR?