search

grimbough / biomaRt

R package providing query functionality to BioMart instances like Ensembl
https://bioconductor.org/packages/biomaRt/
34 stars 13 forks source link

Moving SSL configuration away from onLoad() #41

Closed grimbough closed 3 years ago

grimbough commented 3 years ago

This set of updates moves the determination of SSL configuration settings from happening during package load, to the first time useEnsembl() is called. It also stores the settings in the biomaRt cache, so they will be loaded more quickly for future runs.

codecov-io commented 3 years ago

Codecov Report

Merging #41 (8b5907a) into master (c489ece) will increase coverage by 0.86%. The diff coverage is 71.05%.

Impacted file tree graph

@@            Coverage Diff             @@
##           master      #41      +/-   ##
==========================================
+ Coverage   68.88%   69.75%   +0.86%     
==========================================
  Files           7        7              
  Lines         932      972      +40     
==========================================
+ Hits          642      678      +36     
- Misses        290      294       +4
Impacted Files Coverage Δ
R/ensembl.R 67.85% <42.10%> (-0.57%) :arrow_down:
R/biomaRt.R 59.90% <64.51%> (+<0.01%) :arrow_up:
R/caching.R 95.74% <100.00%> (+4.25%) :arrow_up:
R/ensembl_ssl_settings.R 96.87% <100.00%> (ø)
R/methods-Mart.R 73.68% <100.00%> (+2.53%) :arrow_up:
R/utilityFunctions.R 86.36% <100.00%> (+0.07%) :arrow_up:

Continue to review full report at Codecov.

Legend - Click here to learn more Δ = absolute <relative> (impact), ø = not affected, ? = missing data Powered by Codecov. Last update c489ece...8b5907a. Read the comment docs.