grimbough / msmbstyle

Tufte inspired bookdown template
https://www-huber.embl.de/users/msmith/msmbstyle/
59 stars 17 forks source link

msmbstyle 0.0.9 + bookdown 0.1 problems #16

Closed aridus closed 5 years ago

aridus commented 5 years ago

Good day

I have updated to msmbstyle 0.0.9 with bookdown 0.1 and there are two problems (illustrated here with msmbstyle-master):

1) The header is not present: Screenshot from 2019-05-11 05-51-59

2) Code chunks run in to the margin (i.e. the bottom slider does not appear): Screenshot from 2019-05-11 05-52-36

Would it be possible for you to look into these matters? Our new website (with a book prepared in msmbstyle embedded) is due to go live in the next 1-2 weeks and it would be very helpful if you could find time to look at this).

With grateful thanks.

grimbough commented 5 years ago

Thanks for the report. I'd noticed this rebuilding our book too. It's a top priority for me, should be done early next week. It'll include an update to the CSS for blockquotes too.

aridus commented 5 years ago

Fantastic, thank you: much appreciated!

aridus commented 5 years ago

I see that the header problem is now fixed, thank you!

grimbough commented 5 years ago

Is the code running into the margin fixed too? That was introduced by a change in bookdown that broke my CSS, but I'm hoping it's sorted now.

aridus commented 5 years ago

Unfortunately it still runs into the margin:

Screenshot from 2019-05-17 12-22-26

grimbough commented 5 years ago

I think I'd addressed this locally and not pushed it to Github. Try updating the package and rebuilding.

aridus commented 5 years ago

Thank you. The grey box is now ok (it doesn't extend into the margin, but the code still does:

Screenshot from 2019-05-17 15-24-25

grimbough commented 5 years ago

Weird, for me it looks ok:

image

What browser are you working in? I'm using Chrome. The text overflow behaviour was set to auto so maybe that's different between browsers. I've explicitly set it to scrolling now, so give that a whirl.

aridus commented 5 years ago

I am using Chrome and Firefox on Ubunut - same problem on both. However, the latest update resolves this issue:

Screenshot from 2019-05-17 15-51-31

Thanks again.