search

grimbough / rhdf5

Package providing an interface between HDF5 and R
http://bioconductor.org/packages/rhdf5
59 stars 22 forks source link

Correctly save fixed-width strings with UTF8 encoding. #112

Closed LTLA closed 1 year ago

LTLA commented 2 years ago

Closes #111, e.g., 

library(rhdf5)
h5createFile("ex_hdf5file.h5")
h5write("α ≤ 0.1", "ex_hdf5file.h5", "WHEE")
h5read("ex_hdf5file.h5")
## [1] "α ≤ 0.1"

Haven't written tests or updated the docs, will leave that to you.

codecov[bot] commented 2 years ago

Codecov Report

Merging #112 (6885c69) into master (48bfedb) will increase coverage by 0.03%. The diff coverage is 88.88%.

@@            Coverage Diff             @@
##           master     #112      +/-   ##
==========================================
+ Coverage   78.39%   78.43%   +0.03%     
==========================================
  Files          35       35              
  Lines        1912     1915       +3     
==========================================
+ Hits         1499     1502       +3     
  Misses        413      413
Impacted Files Coverage Δ
R/h5write.R 84.24% <88.88%> (+0.33%) :arrow_up:

Continue to review full report at Codecov.

Legend - Click here to learn more Δ = absolute <relative> (impact), ø = not affected, ? = missing data Powered by Codecov. Last update 48bfedb...6885c69. Read the comment docs.

grimbough commented 2 years ago

Thanks @LTLA. I'm on leave at the moment, but will merge when I'm back.

grimbough commented 1 year ago

I think this has all been addressed. Feel free to re-open #111 if I'm mistaken.