search

grimbough / rhdf5

Package providing an interface between HDF5 and R
http://bioconductor.org/packages/rhdf5
59 stars 22 forks source link

allow custom HDF5 data types in h5createDataset and h5writeDataset #130

Open ilia-kats opened 9 months ago

ilia-kats commented 9 months ago

This useful when one has a custom type, but still wants to use the default HDF5 spaces, DCPLs etc. that these functions provide. For example, when writing logical vectors that are compatible with Python's h5py, one needs to create a custom enum type with H5Tenum_create.

ilia-kats commented 9 months ago

AFAICT the CI is failing somewhere in the testthat package itself, not due to my changes.

codecov[bot] commented 9 months ago

Codecov Report

Attention: 9 lines in your changes are missing coverage. Please review.

Comparison is base (e2e4ef7) 79.03% compared to head (f32940d) 78.70%.

Additional details and impacted files ```diff @@ Coverage Diff @@ ## devel #130 +/- ## ========================================== - Coverage 79.03% 78.70% -0.34% ========================================== Files 36 36 Lines 1994 2005 +11 ========================================== + Hits 1576 1578 +2 - Misses 418 427 +9 ``` | [Files](https://app.codecov.io/gh/grimbough/rhdf5/pull/130?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=Mike+Smith) | Coverage Δ | | |---|---|---| | [R/h5create.R](https://app.codecov.io/gh/grimbough/rhdf5/pull/130?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=Mike+Smith#diff-Ui9oNWNyZWF0ZS5S) | `83.14% <40.00%> (-1.34%)` | :arrow_down: | | [R/h5write.R](https://app.codecov.io/gh/grimbough/rhdf5/pull/130?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=Mike+Smith#diff-Ui9oNXdyaXRlLlI=) | `81.04% <57.14%> (-3.21%)` | :arrow_down: |

:umbrella: View full report in Codecov by Sentry.
:loudspeaker: Have feedback on the report? Share it here.