grimbough / rhdf5

Package providing an interface between HDF5 and R
http://bioconductor.org/packages/rhdf5
60 stars 21 forks source link

h5ls() missing dataset dimension info #49

Closed grimbough closed 4 years ago

grimbough commented 4 years ago

This was reported via email when building rhdf5-2.30.1 for the Debian repositories.

library(testthat)
library(rhdf5)
.
test_check("rhdf5")

── 1. Failure: h5ls supports native (@test_native.R#21)  ───────────────────────
`object` not equal to "3 x 4".
1/1 mismatches
x[1]: " x 4"
y[1]: "3 x 4"

── 2. Failure: h5ls supports native (@test_native.R#23)  ───────────────────────
`object` not equal to "4 x 3".
1/1 mismatches
x[1]: " x 3"
y[1]: "4 x 3"

── 3. Failure: h5ls supports native (@test_native.R#27)  ───────────────────────
`object` not equal to "4 x 3".
1/1 mismatches
x[1]: " x 3"
y[1]: "4 x 3"

── 4. Failure: h5ls supports native (@test_native.R#29)  ───────────────────────
`object` not equal to "3 x 4".
1/1 mismatches
x[1]: " x 4"
y[1]: "3 x 4"

── 5. Failure: h5ls supports native (@test_native.R#38)  ───────────────────────
`object` not equal to "2 x 3 x 4".
1/1 mismatches
x[1]: " x 4"
y[1]: "2 x 3 x 4"

── 6. Failure: h5ls supports native (@test_native.R#41)  ───────────────────────
`object` not equal to "4 x 3 x 2".
1/1 mismatches
x[1]: " x 2"
y[1]: "4 x 3 x 2"

── 7. Failure: h5ls supports native (@test_native.R#46)  ───────────────────────
`object` not equal to "4 x 3 x 2".
1/1 mismatches
x[1]: " x 2"
y[1]: "4 x 3 x 2"

── 8. Failure: h5ls supports native (@test_native.R#49)  ───────────────────────
`object` not equal to "2 x 3 x 4".
1/1 mismatches
x[1]: " x 4"
y[1]: "2 x 3 x 4"

══ testthat results  ═══════════════════════════════════════════════════════════
[ OK: 694 | SKIPPED: 0 | WARNINGS: 0 | FAILED: 8 ]
1. Failure: h5ls supports native (@test_native.R#21).
2. Failure: h5ls supports native (@test_native.R#23).
3. Failure: h5ls supports native (@test_native.R#27).
4. Failure: h5ls supports native (@test_native.R#29).
5. Failure: h5ls supports native (@test_native.R#38).
6. Failure: h5ls supports native (@test_native.R#41).
7. Failure: h5ls supports native (@test_native.R#46).
8. Failure: h5ls supports native (@test_native.R#49).

Error: testthat unit tests failed
Execution halted

It seems to be a third instace of https://support.bioconductor.org/p/101038/ and #16

grimbough commented 4 years ago

This was the result of an unsafe use of sprintf() and should now have been addressed.