search

grimbough / rhdf5

Package providing an interface between HDF5 and R
http://bioconductor.org/packages/rhdf5
60 stars 21 forks source link

UTF-8 file paths and Rtools40 #53

Closed grimbough closed 4 years ago

grimbough commented 4 years ago

Switching to the libhdf5.a compiled by the rwinlib project leads to our test with paths that contain non-ASCII characters to fail on Windows.

  > test_check("rhdf5")
  -- 1. Failure: Non-ASCII filename (@test_H5F.R#41)  ----------------------------
  file.exists(h5File) isn't true.

  == testthat results  ===========================================================
  [ OK: 697 | SKIPPED: 1 | WARNINGS: 0 | FAILED: 1 ]
  1. Failure: Non-ASCII filename (@test_H5F.R#41)
grimbough commented 4 years ago

Added additional tests in https://github.com/grimbough/rhdf5/blob/8ebc015744439170344896e498164d0bd2ae8216/tests/testthat/test_H5F.R#L30 and this seems to be working again now.