search

grimen / python-rootpath

Python project/package root path detection.
https://pypi.org/project/rootpath
MIT License
23 stars 14 forks source link

Infinite loop on windows #4

Closed qwerbzuio closed 3 years ago

qwerbzuio commented 4 years ago

rootpath.detect() runs infinitely on MS Windows if pattern can't be found. The used detection of the system root seems to be non-portable.

Potential fix: https://stackoverflow.com/a/12041606

nagesh-chowdaiah commented 3 years ago

@qwerbzuio Can i work on this ticket?

nagesh-chowdaiah commented 3 years ago

take

nagesh-chowdaiah commented 3 years ago

@grimen I have fixed this issue, please let me to create the PR so that i can submit my changes

grimen commented 3 years ago

Merged this PR, thank you.