search

grimen / python-rootpath

Python project/package root path detection.
https://pypi.org/project/rootpath
MIT License
23 stars 14 forks source link

refactor login in detect function #5

Closed bpmason1 closed 3 years ago

codecov[bot] commented 4 years ago

Codecov Report

Merging #5 into master will increase coverage by 0.25%. The diff coverage is 100%.

Impacted file tree graph

@@            Coverage Diff             @@
##           master       #5      +/-   ##
==========================================
+ Coverage    92.5%   92.75%   +0.25%     
==========================================
  Files           3        3              
  Lines          80       69      -11     
==========================================
- Hits           74       64      -10     
+ Misses          6        5       -1
Impacted Files Coverage Δ
rootpath/detect.py 96.42% <100%> (+1.55%) :arrow_up:

Continue to review full report at Codecov.

Legend - Click here to learn more Δ = absolute <relative> (impact), ø = not affected, ? = missing data Powered by Codecov. Last update 5b48ff9...9b50d4a. Read the comment docs.

grimen commented 3 years ago

Sorry, I don't see the value of this code change - a matter of personal preference I guess.