grimkor / DeckyFileServer

GNU General Public License v3.0
7 stars 1 forks source link

Enable Server option disconnects while downloading videos. #7

Closed Deathstryker closed 7 months ago

Deathstryker commented 8 months ago

Hey, I realize it's by design to disable the file server when not in use, however, when downloading large videos, the Enable Server option disables while downloading. This makes it almost impossible to use when downloading large files. This is on version 0.1.4. Thanks.

grimkor commented 8 months ago

Hey! Let me think of a good way to solve this and I'll see what I can do for you.

Thanks

Deathstryker commented 8 months ago

Honestly, just allowing an option to increase "idle" time before disconnect would be sufficient enough for me. Using Decky recorder, the videos are about 1gb per every 10 minutes (from memory) and I can just about get them downloaded before it disconnects. For me, Decky File Server is disconnecting every 30 seconds (guess). So really, double the time should be enough to get a 10 minute video across.

grimkor commented 8 months ago

It disconnects on a 1 minute idle time, if you refresh or navigate to a file/folder in that minute it will refresh that 1 minute.

Until I get something in the workaround would be to refresh the page within that minute until it is downloaded to keep that timer restarting.

Appreciate the details and I'll try to figure it out this weekend for you.

grimkor commented 8 months ago

To keep you updated I have a potentially working version which I'm going to test over the next day or 2 and make sure it's working as intended.

It's a big change and will see other performance improvements on the web UI side too.

grimkor commented 8 months ago

@Deathstryker if you switch to the testing store for Decky Plugin you can test the new version of DeckyFileServer. I would appreciate it if you can verify that it works for you and allows for longer downloads.

Thanks!

Deathstryker commented 8 months ago

Yes, I noticed it was updated last night. I'll test today and report back. Thanks for the quick response.

On Sun, Jan 21, 2024, 4:46 AM Grimbakor @.***> wrote:

@Deathstryker https://github.com/Deathstryker if you switch to the testing branch for Decky Plugin you can test the new version of DeckyFileServer. I would appreciate it if you can verify that it works for you and allows for longer downloads.

Thanks!

— Reply to this email directly, view it on GitHub https://github.com/grimkor/DeckyFileServer/issues/7#issuecomment-1902572043, or unsubscribe https://github.com/notifications/unsubscribe-auth/AGFWX6KQPO3JX7WH6GQ42IDYPTPWDAVCNFSM6AAAAABBIRKOCGVHI2DSMVQWIX3LMV43OSLTON2WKQ3PNVWWK3TUHMYTSMBSGU3TEMBUGM . You are receiving this because you were mentioned.Message ID: @.***>

Deathstryker commented 8 months ago

I did some testing today and it's still disconnecting on me in the middle of downloading large files. Tested on Android Firefox and Chrome browsers as well as my Windows 11 Desktop Firefox browser. All have the same issue. I am on version 0.1.4-1 of the app.

On Sun, Jan 21, 2024, 11:00 AM Joshua @.***> wrote:

Yes, I noticed it was updated last night. I'll test today and report back. Thanks for the quick response.

On Sun, Jan 21, 2024, 4:46 AM Grimbakor @.***> wrote:

@Deathstryker https://github.com/Deathstryker if you switch to the testing branch for Decky Plugin you can test the new version of DeckyFileServer. I would appreciate it if you can verify that it works for you and allows for longer downloads.

Thanks!

— Reply to this email directly, view it on GitHub https://github.com/grimkor/DeckyFileServer/issues/7#issuecomment-1902572043, or unsubscribe https://github.com/notifications/unsubscribe-auth/AGFWX6KQPO3JX7WH6GQ42IDYPTPWDAVCNFSM6AAAAABBIRKOCGVHI2DSMVQWIX3LMV43OSLTON2WKQ3PNVWWK3TUHMYTSMBSGU3TEMBUGM . You are receiving this because you were mentioned.Message ID: @.***>

grimkor commented 8 months ago

I did some testing today and it's still disconnecting on me in the middle of downloading large files. Tested on Android Firefox and Chrome browsers as well as my Windows 11 Desktop Firefox browser. All have the same issue. I am on version 0.1.4-1 of the app. On Sun, Jan 21, 2024, 11:00 AM Joshua @.> wrote: Yes, I noticed it was updated last night. I'll test today and report back. Thanks for the quick response. On Sun, Jan 21, 2024, 4:46 AM Grimbakor @.> wrote: > @Deathstryker https://github.com/Deathstryker if you switch to the > testing branch for Decky Plugin you can test the new version of > DeckyFileServer. I would appreciate it if you can verify that it works for > you and allows for longer downloads. > > Thanks! > > — > Reply to this email directly, view it on GitHub > <#7 (comment)>, > or unsubscribe > https://github.com/notifications/unsubscribe-auth/AGFWX6KQPO3JX7WH6GQ42IDYPTPWDAVCNFSM6AAAAABBIRKOCGVHI2DSMVQWIX3LMV43OSLTON2WKQ3PNVWWK3TUHMYTSMBSGU3TEMBUGM > . > You are receiving this because you were mentioned.Message ID: > @.***> >

Hey so if you go to the Decky Plugin settings and under General there is a setting called "Store Channel". If you change this to "Testing" you should then be able to see the update 0.2.0 in the store.

Deathstryker commented 8 months ago

My mistake. I thought I had the test branch selected in the settings. I've downloaded 0.2.0 but now my issue is the Enable Server option won't stay enabled. I'll enable it and then it immediately disables in about 2-3 seconds. Tried changing the shared folder to see if that was the issue and the same thing happened.

On Sun, Jan 21, 2024, 8:23 PM Grimbakor @.***> wrote:

I did some testing today and it's still disconnecting on me in the middle of downloading large files. Tested on Android Firefox and Chrome browsers as well as my Windows 11 Desktop Firefox browser. All have the same issue. I am on version 0.1.4-1 of the app. … <#m3417159392741218048> On Sun, Jan 21, 2024, 11:00 AM Joshua @.> wrote: Yes, I noticed it was updated last night. I'll test today and report back. Thanks for the quick response. On Sun, Jan 21, 2024, 4:46 AM Grimbakor @.> wrote: > @Deathstryker https://github.com/Deathstryker https://github.com/Deathstryker if you switch to the > testing branch for Decky Plugin you can test the new version of > DeckyFileServer. I would appreciate it if you can verify that it works for > you and allows for longer downloads. > > Thanks! > > — > Reply to this email directly, view it on GitHub > <#7 (comment) https://github.com/grimkor/DeckyFileServer/issues/7#issuecomment-1902572043>,

or unsubscribe > https://github.com/notifications/unsubscribe-auth/AGFWX6KQPO3JX7WH6GQ42IDYPTPWDAVCNFSM6AAAAABBIRKOCGVHI2DSMVQWIX3LMV43OSLTON2WKQ3PNVWWK3TUHMYTSMBSGU3TEMBUGM . > You are receiving this because you were mentioned.Message ID: > @.***>

Hey so if you go to the Decky Plugin settings and under General there is a setting called "Store Channel". If you change this to "Testing" you should then be able to see the update 0.2.0 in the store.

— Reply to this email directly, view it on GitHub https://github.com/grimkor/DeckyFileServer/issues/7#issuecomment-1902855646, or unsubscribe https://github.com/notifications/unsubscribe-auth/AGFWX6IARBP6HXWEMIJBV2DYPW5PTAVCNFSM6AAAAABBIRKOCGVHI2DSMVQWIX3LMV43OSLTON2WKQ3PNVWWK3TUHMYTSMBSHA2TKNRUGY . You are receiving this because you were mentioned.Message ID: @.***>

grimkor commented 8 months ago

@Deathstryker very odd, could you send the logs when possible? There will be 2 sets of logs in /tmp/deckyfileserver.log and /home/deck/logs/DeckyFileServer/<latest_log_file> as it sounds like the plugin is running into an error when starting the web server.

Thank you!

Deathstryker commented 8 months ago

I looked at the log file myself and the error stated that the port must be over 8000. I had mine set below that. I think currently, DeckyFileServer recommends over 1024 so the suggestion should probably be raised. After I changed my port, it seems to work fine and waited until I finished my download before shutting down.

One other suggestion I have is if you change the directory, it doesn't update until after the file server turns off and you turn it back on. Could you make it so if the file server is on and you change the directory, it automatically turns off the file server for you? I realize this is a separate issue and I can open a new report for this if you wish.

Outside of these suggestions it seems to run fine now.

On Mon, Jan 22, 2024, 8:18 PM Grimbakor @.***> wrote:

@Deathstryker https://github.com/Deathstryker very odd, could you send the logs when possible? There will be 2 sets of logs in /tmp/deckyfileserver.log and /home/deck/logs/DeckyFileServer/ as it sounds like the plugin is running into an error when starting the web server.

Thank you!

— Reply to this email directly, view it on GitHub https://github.com/grimkor/DeckyFileServer/issues/7#issuecomment-1905119995, or unsubscribe https://github.com/notifications/unsubscribe-auth/AGFWX6PKT7GMF6NL3LTXR2TYP4FXPAVCNFSM6AAAAABBIRKOCGVHI2DSMVQWIX3LMV43OSLTON2WKQ3PNVWWK3TUHMYTSMBVGEYTSOJZGU . You are receiving this because you were mentioned.Message ID: @.***>

grimkor commented 8 months ago

I've changed the restriction back to 1024 as the low-end of the ports. I must have been daydreaming during rewrite.

As for the settings I've decided to go in a different direction, to greatly reduce the complexity and risk of issues. When the server is active the settings button will be disabled. Appreciate the feedback.

grimkor commented 7 months ago

Closing this issue as the patched version is now available on the regular Decky store. Please download it from there and thank you for the report.