search

grimmdude / MidiPlayerJS

♬ MIDI parser & player engine for browser or Node. As a parser converts MIDI events into JSON. Works well with single or multitrack MIDI files.
https://grimmdude.com/MidiPlayerJS/
MIT License
357 stars 52 forks source link

File loads, then waits forever to actually play #61

Open Andrew-J-Larson opened 4 years ago

Andrew-J-Larson commented 4 years ago

Seems that this might also be related to tempo issues... but I'm not so sure here... but it takes a while for it to actually start playing, and then stays quiet again after the first part for much longer than it should.

The file that is having the issues is Deadmau5 - Strobe.mid

Andrew-J-Larson commented 4 years ago

I'm starting to think it's not waiting a long time to play, that it's just starting off with a very slow tempo, and the start happens to be quiet, because this file appears to have an issue too...

https://cdn-25.anonfiles.com/d1XaEd13o9/4870b07e-1590208805/tau2.5.9.mid

But, it's not quite at the beginning, so you can tell it's being extremely slow when it shouldn't be.

Andrew-J-Larson commented 4 years ago

Duration time is fixed, but now the time remaining isn't updating, at least for the Strobe midi

Andrew-J-Larson commented 4 years ago

I found another issue since you fixed #62... Player.isPlaying() no longer shows if something is playing or not

Andrew-J-Larson commented 4 years ago

Alright, under closer inspection, the getSongTime, getSongTimeRemaining, and isPlaying functions no longer work now because of the fix in #62

Andrew-J-Larson commented 4 years ago

Your commit in https://github.com/grimmdude/MidiPlayerJS/commit/9c3bc8ddd1f0eed026d6be6e9d4f73bcdd0d637f fixed the above issue, thanks!

Andrew-J-Larson commented 4 years ago

Duration time is still incorrect for the https://cdn-25.anonfiles.com/d1XaEd13o9/4870b07e-1590208805/tau2.5.9.mid file now that I checked it again... but the other file is doing just fine.

At least the tau2.5.9.mid plays correctly now though.

Andrew-J-Larson commented 1 year ago

Just realized that you probably don't have access to the original midi file anymore (must of expired at the link).

So, uploaded it to Mediafire for easy download: