Marker event has no marker name attached

grimmdude / MidiPlayerJS

♬ MIDI parser & player engine for browser or Node. As a parser converts MIDI events into JSON. Works well with single or multitrack MIDI files.

https://grimmdude.com/MidiPlayerJS/

MIT License

357 stars 52 forks source link

Marker event has no marker name attached #85

Open serg472 opened 2 years ago

serg472 commented 2 years ago

A marker command inside a midi is followed by a string containing the marker name. Currently the marker name is not attached to the event, which can be easily fixed:

case 0x06:
  // Marker
  eventJson.name = 'Marker';
  eventJson.string = this.getStringData(eventStartIndex); //FIX
  break;

Thanks.