search

grimmdude / MidiPlayerJS

♬ MIDI parser & player engine for browser or Node. As a parser converts MIDI events into JSON. Works well with single or multitrack MIDI files.
https://grimmdude.com/MidiPlayerJS/
MIT License
357 stars 52 forks source link

Overlapping Notes in React App with MidiPlayer #97

Open 15077693d opened 1 year ago

15077693d commented 1 year ago

Thank you for creating this project. I've noticed a potential issue while using the React app with MidiPlayer. When I click play, the notes seem to overlap. I wanted to bring this to your attention and provide an example in this sandbox: https://codesandbox.io/s/sax-practice-u4zl99?file=/src/App.tsx.

Andrew-J-Larson commented 1 year ago

Not a bug, but sounds like it could be a useful (togglable) feature to prematurely end a note when a new one starts on wind/brass instruments.