Closed jpw closed 4 years ago
Awesome, thanks @jpw looks great 👍.
I'd say for future PRs let's leave changes to /docs
directory out of commits. Makes it easier to see what's actually changing. We can rebuild docs when version updates are released.
I'd say for future PRs let's leave changes to /docs directory out of commits.
Roger that, thanks @grimmdude 🙂
Hello! I've been doing some more tinkering 🙂
I was adding
nyc
locally to get a view on the code coverage before looking at the code in more detail, and thought I'd do a PR in case it's useful.nyc
for code coverage. Not so informative ran against the built file, but nice i think?nyc
outputwriter.js
manages node DEP0005 warning fornew Buffer()
, which is a dangerous use ofBuffer()
. I went for the option that drops support for node < 6, am guessing that's not a problem for you.mocha
to 6.2.0 (no special reason for that, but it seems to work fine)