grimmdude / MidiWriterJS

♬ A JavaScript library which provides an API for programmatically generating and creating expressive multi-track MIDI files and JSON.
MIT License
547 stars 58 forks source link

adds nyc, splits test file, updates mocha, DEP0005 #64

Closed jpw closed 4 years ago

jpw commented 4 years ago

Hello! I've been doing some more tinkering 🙂

I was adding nyc locally to get a view on the code coverage before looking at the code in more detail, and thought I'd do a PR in case it's useful.

image

grimmdude commented 4 years ago

Awesome, thanks @jpw looks great 👍.

I'd say for future PRs let's leave changes to /docs directory out of commits. Makes it easier to see what's actually changing. We can rebuild docs when version updates are released.

jpw commented 4 years ago

I'd say for future PRs let's leave changes to /docs directory out of commits.

Roger that, thanks @grimmdude 🙂