grimmdude / MidiWriterJS

♬ A JavaScript library which provides an API for programmatically generating and creating expressive multi-track MIDI files and JSON.

MIT License

557 stars 60 forks source link

Vexflow conversion enhancements #80

Closed AnthoChamb closed 3 years ago

AnthoChamb commented 3 years ago

Added multiple dots and tupplet support for Vexflow conversion. Also added an option to add Vexflow rendered accidentals to the pitch conversion. Decided to default that option to false since there are differences between the internal and the rendered data of a tickable and that may cause unintended results to people trusting only the internals for the output. I am open to any revision of this implementation. Finally, I added some tests to cover these new cases.

grimmdude commented 3 years ago

Very cool, I've been meaning to flesh this out more. Thanks!

grimmdude commented 1 year ago

20

https://github.com/0xfe/vexflow/issues/351