grimreaper / wolf

Automatically exported from code.google.com/p/wolf
0 stars 0 forks source link

Pronouns are unnecessary #89

Open GoogleCodeExporter opened 9 years ago

GoogleCodeExporter commented 9 years ago
What steps will reproduce the problem?
1. Kill someone.
2. Read message.
3. See S/He, (s)he, his/her, etc in messages
4. ???
5. Profit

What is the expected output? What do you see instead?
No pronouns. Pronouns are not needed in any of the contexts.

What version of the product are you using? On what operating system?
production

Please provide any additional information below.
<elky> i had a quick look last night when making my patch and i didn't see 
anything that couldn't be worded to not require a pronoun
<variable> elky: feel free
<variable> elky: one important thing to note
<variable> do not mention a user's nick in a command which has no rate limiting
<elky> i wouldn't add things that aren't already in messages
<variable> exactl
<variable> * exactly
<variable> anyways
<variable> elky: please submit this patch
<variable> I'll gladly accept if/when I have time

This patch was exported from my local repo with "hg export tip" and should be 
importable with "hg import pronouns.patch".

Original issue reported on code.google.com by meli...@meldraweb.com on 26 May 2013 at 1:12

Attachments:

GoogleCodeExporter commented 9 years ago
Revised based on rww's input.

Import instructions remain the same.

Original comment by meli...@meldraweb.com on 26 May 2013 at 11:25

Attachments:

GoogleCodeExporter commented 9 years ago
Well, ok, the filename in the instructions changes :P

Original comment by meli...@meldraweb.com on 26 May 2013 at 11:26

GoogleCodeExporter commented 9 years ago
Chauffer is finding more instances, i will update later.

Original comment by meli...@meldraweb.com on 27 May 2013 at 12:28

GoogleCodeExporter commented 9 years ago
This should be the rest of them (sans villagergame.py; I don't know who uses 
that or if they would be upset with this change.)

Original comment by meli...@meldraweb.com on 28 May 2013 at 12:45

Attachments: