grinnellm / SpawnIndex

:fish: :egg: Calculate the Pacific Herring spawn index
MIT License
0 stars 2 forks source link

Vignette fails on `devtools::check()` #20

Closed grinnellm closed 3 years ago

grinnellm commented 3 years ago

==> devtools::check()

Updating SpawnIndex documentation Writing NAMESPACE Loading SpawnIndex Writing NAMESPACE -- Building --------------------------------------------------------------------------------- SpawnIndex -- Setting env vars:

Exited with status 1.

grinnellm commented 3 years ago

Tried this but it didn't seem to work.

grinnellm commented 3 years ago

Seems like any vignette fails, even if I just try the one created by usethis::use_vignette("my-vignette"). If I delete the vignettes folder, all works OK.

grinnellm commented 3 years ago

Now this doesn't fail (since I omitted the vignette from the check in this commit), but there are two warnings:

checking files in 'vignettes' ... WARNING Files in the 'vignettes' directory but no files in 'inst/doc': 'Introduction.Rmd'

checking package vignettes in 'inst/doc' ... WARNING dir.exists(dir) is not TRUE Package vignette without corresponding single PDF/HTML: 'Introduction.Rmd'

grinnellm commented 3 years ago

Not sure why, but this is working now.

andrew-edwards commented 3 years ago

Did you do build_vignettes() at some point? Have to be careful as that uses library(pkgname) which may not be as up-to-date as your local version in your directory (loaded using load_all(). So maybe you updated it in your library and then it worked.

grinnellm commented 3 years ago

I may have, but I can't recall. I did update all my packages including R recently, so maybe that was it?