search

grinnellplans / grinnellplans-php

Automatically exported from code.google.com/p/grinnellplans
Other
7 stars 7 forks source link

add meta viewport tag to tableless interface, login screen, and a few more pages for better mobile compat #298

Closed mrwweb closed 11 months ago

mrwweb commented 1 year ago

I added the viewport tag to the tableless interface, but not the legacy interface with tables which was the general consensus on #179.

I also added it to the login screen, FAQ page, TOS page, donations page (seems to not be working right?), and stylesheet reset page (I didn't know about that one!).

On index.php, I also removed a few lines of commented-out CSS and added in a single ruleset to make sure the plans logo is responsive. It was extremely tempting to cleanup HTML markup and line indents, but I managed to resist.

I didn't try very hard, but I didn't see any obvious instructions for testing this locally, so I haven't. I'm hoping these changes are minimal enough and only targeted at markup so the chances of any real breakage seem really low.

If it would be helpful, I'd be happy to draft some language for mods to post on the home page (or just [css]?). Just ask :)

What else can I do to help get this out?

acohn commented 11 months ago

I've tried this out on a non-prod instance of Plans. The Slate default stylesheet looks good. The Libre stylesheet is moderately broken - it loads with a zoomed-in view. I think this is acceptable - merging. Should be live on grinnellplans.com in a few minutes.

(My personal stylesheet is very broken, but 🤷)