Open mrwweb opened 11 months ago
This all sounds like good stuff, and like it's unlikely to cause problems with anything else and therefore shouldn't require much regression testing. :+1: from me.
After double-posting this issue (doik, my bad), here are some proposed values and a few questions:
name
: Grinnell Plansshort_name
: [plans]? Plans?display
: minimal-ui
or standalone
description
: Your favorite independent Grinnell College social network.categories
: social
icon
: image filesshortcuts
: I'd propose (in order) Home, Edit Plan, Quicklove, and maybe Preferencesstart_url
: https://grinnellplans.com
id
: https://grinnellplans.com
background_color
: #DA291C
Notes:
theme_color
which is fun but can be pretty opinionated.display_override
if we determine that we want a preferred display with a fallback to something more widely supported.I just searched and I also don't seem to have a source for the logo. I swear I've seen or heard of one, though. Maybe @ianatha knows?
Those proposed values look good to me and in general I trust your judgement when it comes to answering questions like (3).
@iangreenleaf Appreciate the trust :) I'm curious, do you think a minimal-ui
that supports the back button, refresh, etc. would be helpful? I lean toward yes; we probably don't want to totally obfuscate the webby-ness of Plans. But maybe the whole point of doing this is to make it as app-like as possible. I might need to do some testing and see how mobile OS nav-ing (mostly back functions) work in the various display modes.
I think I lean towards yes too. We're far enough from being app-like that I think it probably is wise to maintain some amount of web chrome. But of course, it mostly depends how that plays out in practice...
With trends toward Progressive Web Apps, new support for installing websites in MacOS/iOS, etc. it strikes me as a good idea to add/update the following things to Plans:
site.webmanifest
file that definesname
(Grinnell Plans),short_name
(Plans),start_url
(https:\//grinnellplans.com/home.php), and probably thedisplay
type (standalone?). I don't think defining atheme_color
orbackground_color
makes sense as that seems likely to clash with most stylesheets and light/dark preferencesOver time, this would improve the experience for people "installing" plans on their home screens/task bars/etc.
I can't think of a downside, but I am very curious if people can think of extra considerations or potential downsides. I'm happy to submit the PR if at least a couple people think it's worth doing.