search

grinsfem / grins

Multiphysics Finite Element package built on libMesh
http://grinsfem.github.io
Other
47 stars 39 forks source link

Bring in --enable-werror and --enable-paranoid-warnings from libMesh #548

Open pbauman opened 6 years ago

pbauman commented 6 years ago

libMesh/libmesh#1797, libMesh/libmesh#1800, libMesh/libmesh#1812

We don't want to just take those by default when grabbing libMesh flags, I think, better to just configure separately on the GRINS side.

roystgnr commented 6 years ago

Taking the libMesh ANY_WERROR_FLAG value ought to be safe, if you want us to add something on the libMesh side to export it.

Taking libMesh ANY_PARANOID_FLAGS would be safe by itself, but not in combination with -Werror, because I expect the sequence of "Roy notices a new compiler warning option, fixes all the libMesh warnings it triggers, then adds it to the list of libMesh paranoid warnings" will happen over and over again, and if GRINS just scarfs the libMesh list then any --enable-werror --enable-paranoid-warnings builds will suddenly fail after a corresponding libMesh upgrade.