Slightly Refactor Incompressible Fluids

grinsfem / grins

Multiphysics Finite Element package built on libMesh

http://grinsfem.github.io

Other

47 stars 39 forks source link

Slightly Refactor Incompressible Fluids #588

Closed pbauman closed 5 years ago

pbauman commented 5 years ago

There was actually a bug in Stokes::mass_residual. Getting rid of a bit of code duplication. I would like to template on dimension similar to what happened in solids, but that is a larger project with less priority.

roystgnr commented 5 years ago

Wait, seriously?? What was the bug? I can't make it out from the diff.

pbauman commented 5 years ago

Wait, seriously?? What was the bug? I can't make it out from the diff.

Diff is huge so it's hard to make out (aside from the many other valid reasons you have).

Here

needs to be elem_solution_rate_derivative(). I think it's just leftover from once-upon-a-time when TimeSolvers were refactored and nobody did Stokes, so we never noticed. (We noticed when monkeying with FSI for test cases).